Skip to content

Commit

Permalink
linuxManualConfig: forbid config errors on aarch64
Browse files Browse the repository at this point in the history
It's not a nice experience to wait for a kernel build, only to notice
the options you set didn't actually do anything, because Nixpkgs'
kernel configuration script just prints a warning if an option that
should have been set isn't set in the final kernel config.

Ideally, I think we'd never allow config errors, but we certainly
don't have to torelate them for aarch64, when CI for kernel changes
can ensure we don't accidentally break the build with x86-specific
options.

I've tested that configuration of all mainline kernels still works on
aarch64.
  • Loading branch information
alyssais committed Dec 17, 2024
1 parent a4626b9 commit 277d420
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pkgs/os-specific/linux/kernel/generic.nix
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ lib.makeOverridable ({ # The kernel source tarball.
# symbolic name and `patch' is the actual patch. The patch may
# optionally be compressed with gzip or bzip2.
kernelPatches ? []
, ignoreConfigErrors ? stdenv.hostPlatform.linux-kernel.name != "pc"
, ignoreConfigErrors ?
!lib.elem stdenv.hostPlatform.linux-kernel.name [ "aarch64-multiplatform" "pc" ]
, extraMeta ? {}

, isZen ? false
Expand Down

0 comments on commit 277d420

Please sign in to comment.