sss_code: init at 0.2.0 #302495
sss_code: init at 0.2.0 #302495
Conversation
ofborg
bot
added
10.rebuild-darwin: 0
There was a problem hiding this comment.
- Please move to
pkgs/by-name. Other directories needs top-level reference or package sets reference. - Looks like you are contributing for the first time. Please add your name to
maintainers-maintainer-list.nixfollowing its examples. - It's recommended to leave some blank lines between attributes to improve readability. You can refer to how other packages do it.
|
Hello @Aleksanaa :)
Please review these changes, and let me know if there's anything else I need to address. Thanks you |
Aleksanaa
removed
10.rebuild-darwin: 0
ofborg
bot
added
8.has: package (new)
krovuxdev
force-pushed
the
sss/v0.1.8
branch
2 times, most recently
from
babd5c0 to
b003a4d
Compare
|
Hi @Aleksanaa, could you please review the code to see if it's okay now? |
|
Please squash all your commits leaving only two:
|
|
@Aleksanaa Hello, thank you for bringing it to my attention. Could you please review my commits to see if they are okay? |
|
The maintainer addition commit message is specified in https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#commit-conventions. |
Ok, thank you, and now please, review my commits to see if they are correct |
|
@ofborg eval |
pkgs/by-name/ss/sss/package.nix
Outdated
| src = fetchFromGitHub { | ||
| owner = "SergioRibera"; | ||
| repo = "sss"; | ||
| rev = "sss_code/v{version}"; |
There was a problem hiding this comment.
| rev = "sss_code/v{version}"; | |
| rev = "sss_code/v${version}"; |
|
Done! |
|
@ofborg eval |
|
@ofborg build |
|
@ofborg build sss_code |
@ofborg build sss_code |
|
@Aleksanaa And why this error of tauri? |
|
ahhh now I see, there is a tauri in cargo.lock. ok |
pkgs/by-name/ss/sss_code/package.nix
Outdated
| buildInputs = [ fontconfig freetype libxcb ]; | ||
|
|
||
| meta = with lib; { | ||
| description = "A CLI/Lib to take amazing screenshot of code"; |
There was a problem hiding this comment.
According to the recommendations for meta attributes description should not start with an article and avoid subjective language, hence I propose to use the following shortened description from the projects readme:
| description = "A CLI/Lib to take amazing screenshot of code"; | |
| description = "Libraries and tools for building screenshots in a high-performance image format"; |
There was a problem hiding this comment.
@afh it's ready. Thank you, I changed the description and also made changes to the code because the package was updated.
github-actions
bot
added
the
8.has: maintainer-list (update)
krovuxdev
force-pushed
the
sss/v0.1.8
branch
from
77154bd to
55db8ed
Compare
|
Hey @Aleksanaa @afh What do you think about this PR? Ready to merge, or does it need more tweaks? |
pkgs/by-name/ss/sss_code/package.nix
Outdated
| cargoLock = { | ||
| lockFile = ./Cargo.lock; | ||
| outputHashes = { | ||
| "mouse_position-0.1.3" = "sha256-aYgWaozAECw+RzD2cOT7OxYzKJd2MlLsXkqW27BjSwI="; | ||
| }; | ||
| }; |
There was a problem hiding this comment.
| cargoLock = { | |
| lockFile = ./Cargo.lock; | |
| outputHashes = { | |
| "mouse_position-0.1.3" = "sha256-aYgWaozAECw+RzD2cOT7OxYzKJd2MlLsXkqW27BjSwI="; | |
| }; | |
| }; | |
| useFetchCargoVendor = true; | |
| cargoHash = ""; |
Then we do not need to copy Cargo.lock here
There was a problem hiding this comment.
@FliegendeWurst Thank you for the suggestion, I really appreciate your help! :D
pkgs/by-name/ss/sss_code/package.nix
Outdated
| # Removed 'sss' command due to version differences and to separate commands. | ||
| postInstall = '' | ||
| rm -f $out/bin/sss | ||
| ''; |
There was a problem hiding this comment.
| # Removed 'sss' command due to version differences and to separate commands. | |
| postInstall = '' | |
| rm -f $out/bin/sss | |
| ''; | |
| cargoBuildFlags = [ "-p" "sss_code" ]; |
Should have the same effect, and even saves some compile time.
There was a problem hiding this comment.
I didn’t know about this, and it’s really helpful. I’ll make the change. Appreciate it!
| fontconfig | ||
| libxcb | ||
| ]; | ||
|
|
There was a problem hiding this comment.
| doCheck = false; # no tests | |
The tests take quite some time to compile otherwise.
There was a problem hiding this comment.
@FliegendeWurst Okay, I'll change it.
sss_code: init at 0.2.0 sss_code: init at 0.2.0 sss_code: init at 0.2.0
wegank
added
the
12.approvals: 1
Description of changes
sss is a command tools for screenshots and code snippets.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.