Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nextcloud-talk-desktop: init at 1.0.0 #302781

Merged
merged 1 commit into from
Dec 15, 2024
Merged

nextcloud-talk-desktop: init at 1.0.0 #302781

merged 1 commit into from
Dec 15, 2024

Conversation

kashw2
Copy link
Contributor

@kashw2 kashw2 commented Apr 9, 2024 •
edited
Loading

Description of changes

closes #253243

https://nextcloud.com/talk/
https://github.com/nextcloud/talk-desktop

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@kashw2 kashw2 changed the title nextcloud-talk: init @ 0.27.0 nextcloud-talk: init at 0.27.0 Apr 9, 2024
@kashw2
Copy link
Contributor Author

kashw2 commented Apr 9, 2024

Result of nixpkgs-review pr 302781 run on x86_64-linux 1

1 package built:
  • nextcloud-talk

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 9, 2024
@prusnak
Copy link
Member

prusnak commented Apr 10, 2024 •
edited
Loading

I think the package should be named nextcloud-talk-desktop to make it obvious this is the client part, not the server.

@kashw2 kashw2 changed the title nextcloud-talk: init at 0.27.0 nextcloud-talk-desktop: init at 0.27.0 Apr 11, 2024
@kashw2 kashw2 changed the title nextcloud-talk-desktop: init at 0.27.0 nextcloud-talk-desktop: init at 0.29.0 Apr 24, 2024
@kashw2 kashw2 changed the title nextcloud-talk-desktop: init at 0.29.0 nextcloud-talk-desktop: init at 0.39.0 Oct 20, 2024
@kashw2 kashw2 force-pushed the nextcloud-talk branch 2 times, most recently from 7fde179 to 9d78c5a Compare October 20, 2024 15:42
@Thatoo
Copy link

Thatoo commented Nov 1, 2024

any news on this package?

@RamReso
Copy link
Contributor

RamReso commented Nov 10, 2024

I'm also still interested. Is there a reason why this PR is not merged?

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Nov 27, 2024
@CaptainJawZ
Copy link
Contributor

@_@ pardon the intrusion with the suggested changes, not sure if it's appropriate to upgrade apps that have not been merged yet, but since the official 1.0.0 release came out, I figured this could be bumped to that instead.

@FliegendeWurst FliegendeWurst added the 2.status: needs-changes This PR needs changes by the author label Dec 8, 2024
@kashw2 kashw2 changed the title nextcloud-talk-desktop: init at 0.39.0 nextcloud-talk-desktop: init at 1.0.0 Dec 13, 2024
@kashw2 kashw2 removed the 2.status: needs-changes This PR needs changes by the author label Dec 13, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 10.rebuild-linux: 1 labels Dec 13, 2024
@FliegendeWurst FliegendeWurst merged commit 02abbe5 into NixOS:master Dec 15, 2024
41 of 42 checks passed
@Thatoo
Copy link

Thatoo commented Dec 15, 2024 •
edited
Loading

Great news. Woud it be possible to backport it to 24.11?

@FliegendeWurst FliegendeWurst added the backport release-24.11 Backport PR automatically label Dec 15, 2024
@nix-backports
Copy link

nix-backports bot commented Dec 15, 2024

Successfully created backport PR for release-24.11:

@nix-backports nix-backports bot mentioned this pull request Dec 15, 2024
Merged
1 task
@Thatoo
Copy link

Thatoo commented Dec 21, 2024

I have tested it on NixOS 24.11 Cosmic and unfortunately, this app doesn't appear in the app launcher as if no .desktop file could be find by the system.
Any idea why?

@FliegendeWurst FliegendeWurst mentioned this pull request Dec 21, 2024
Merged
2 tasks
@FliegendeWurst
Copy link
Member

That is because there was no .desktop file. Check #367079

@kashw2 kashw2 deleted the nextcloud-talk branch December 21, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FliegendeWurst FliegendeWurst FliegendeWurst left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: Nextcloud Talk Desktop
7 participants
@kashw2 @prusnak @Thatoo @RamReso @CaptainJawZ @FliegendeWurst @SuperSandro2000