wrapQemuBinfmtP: don't use pkgsStatic #341779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no reason to bring in a whole cross toolchain just to build a zero-dependency C program.
ofborg
bot
added
10.rebuild-darwin: 0
|
@ofborg test systemd-binfmt |
Comment on lines
5
to
6
| # The wrapper has to be static so LD_* environment variables | ||
| # cannot affect the execution of the wrapper itself. |
There was a problem hiding this comment.
Please check whether this comment is still applicable.
There was a problem hiding this comment.
How's that relevant to this PR? We're still building a static executable, just not via pkgsStatic.
There was a problem hiding this comment.
Ah. I didn't realize adding that to buildInputs would create a static binary 👍
There was a problem hiding this comment.
It doesn't, but passing -static to the compiler does. You have to do this whether using pkgsStatic or not, so no change is needed here.
FliegendeWurst
approved these changes
Dec 4, 2024
wegank
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
There's no reason to bring in a whole cross toolchain just to build a zero-dependency C program.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.