Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apftool-rs: init at 0-unstable-2024-01-05 #354398

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

colemickens
Copy link
Member

Package this tool: https://github.com/suyulin/apftool-rs

at an unstable revision.

It's the most reliable tool I've found for unpacking various rockchip images.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 8, 2024
@KiaraGrouwstra
Copy link
Contributor

Result of nixpkgs-review pr 354398 run on x86_64-linux 1

1 package built:
  • apftool-rs

@KiaraGrouwstra
Copy link
Contributor

code looks good and the package works, but could you format it as per CI?

@colemickens colemickens force-pushed the colemickens/apftool-rs branch from 4735dd1 to 9204f0b Compare November 15, 2024 22:48
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 17, 2024
@colemickens colemickens force-pushed the colemickens/apftool-rs branch from 9204f0b to 31e6d66 Compare December 18, 2024 18:33
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 18, 2024
@FliegendeWurst FliegendeWurst changed the title apftool-rs: init at unstable-2024-01-05 apftool-rs: init at 0-unstable-2024-01-05 Dec 19, 2024
@colemickens colemickens force-pushed the colemickens/apftool-rs branch from 31e6d66 to b80bab4 Compare December 22, 2024 01:34
@FliegendeWurst FliegendeWurst merged commit cc029f1 into NixOS:master Dec 23, 2024
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants