Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oracle-instantclient: support aarch64-darwin #366184

Merged
merged 1 commit into from
Dec 22, 2024
Merged

oracle-instantclient: support aarch64-darwin #366184

merged 1 commit into from
Dec 22, 2024

Conversation

lvitaly
Copy link
Contributor

@lvitaly lvitaly commented Dec 18, 2024

Description

Add support for aarch64-darwin (m1) for oracle-instantclient.
https://www.oracle.com/database/technologies/instant-client/macos-arm64-downloads.html

This is a fresh update/duplicate of #335529.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 18, 2024
@lvitaly
Copy link
Contributor Author

lvitaly commented Dec 18, 2024

@aca @SuperSandro2000 @joshuata
Hey guys, I hope you are well and okay with duplicating @aca's PR to merge it ASAP 🙏

@lvitaly lvitaly force-pushed the oracle-instantclient-aarch64-darwin branch 3 times, most recently from cd56848 to 8f24bf6 Compare December 18, 2024 15:38
@lvitaly lvitaly force-pushed the oracle-instantclient-aarch64-darwin branch from 8f24bf6 to 8f33c0d Compare December 18, 2024 23:08
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1-10 labels Dec 19, 2024
@lvitaly
Copy link
Contributor Author

lvitaly commented Dec 19, 2024

Hey, @SuperSandro2000, I’ve addressed your comment. Please take a look 🙏 Thanks.

@lvitaly
Copy link
Contributor Author

lvitaly commented Dec 22, 2024

Kind reminder 😇

@SuperSandro2000 SuperSandro2000 merged commit 49fffe9 into NixOS:master Dec 22, 2024
40 checks passed
@lvitaly lvitaly deleted the oracle-instantclient-aarch64-darwin branch December 23, 2024 12:03
@lvitaly lvitaly mentioned this pull request Dec 23, 2024
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lvitaly @SuperSandro2000