-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xorg.xorgserver: fix darwin build #366504
xorg.xorgserver: fix darwin build #366504
Conversation
disable libunwind detection as the configure step will detect the libunwind pkg-config stub but then the code will uses the unimplemented function unw_strerror. the pkg-config stub was added in ec40b04
ece5401
to
85ddc5d
Compare
This is more of libunwind from nongnu being the only libunwind implementation to have |
it's easy enough to implement but it's out of scope for this PR |
Yeah, I was just adding some context since someone I know also ran into this problem. |
and getting LLVM to add unw_strerror still will not fix darwin until darwin adds it to their nonetheless -- none of this should be blocking on this PR. |
|
thanks! this can get backported to |
Successfully created backport PR for |
this change can be backported to release-24.11
disable libunwind detection as the configure step will detect the libunwind pkg-config stub but then the code will uses the unimplemented function unw_strerror.
the pkg-config stub was added in ec40b04
https://hydra.nixos.org/build/278453569/nixlog/2/tail
fixes: #359772
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.