Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-24.11] gnomeExtensions.gsconnect: patch also gsconnect-preferences executable script #366563

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

nix-backports[bot]
Copy link

@nix-backports nix-backports bot commented Dec 19, 2024

Bot-based backport to release-24.11, triggered by a label in #365869.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

@github-actions github-actions bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Dec 19, 2024
@nix-owners nix-owners bot requested a review from jtojnar December 19, 2024 14:45
@bjornfor
Copy link
Contributor

I'm not sure if this fixes the whole issue, but it's at least a step in the right direction. (Or my test setup isn't right and it does indeed fix everything.)

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 19, 2024
@bjornfor
Copy link
Contributor

$ nix-build -A gnomeExtensions.gsconnect && ./result/share/gnome-shell/extensions/[email protected]/gsconnect-preferences 
/nix/store/247fsl6plmb172l3375s7rxg4icr1rd9-gnome-shell-extension-gsconnect-58

(gjs:968308): Gjs-CRITICAL **: 15:52:00.506: JS ERROR: Error: Requiring GIRepository, version none: Typelib file for namespace 'GObject', version '2.0' not found
require@resource:///org/gnome/gjs/modules/esm/gi.js:16:28
@gi://GIRepository:3:25


(gjs:968308): Gjs-CRITICAL **: 15:52:00.507: Module file:///home/bf/nixpkgs/result/share/gnome-shell/extensions/[email protected]/gsconnect-preferences threw an exception

@bjornfor
Copy link
Contributor

Ping @doronbehar. Please see above.

@doronbehar
Copy link
Contributor

doronbehar commented Dec 19, 2024

HMM I'm seeing this on master too. @jtojnar ran:

gnome-extensions prefs [email protected]

But you'd have to launch a GNOME session with this derivation of the extension I'm pretty sure...

@bjornfor
Copy link
Contributor

Yes, I think my way of running it isn't supposed to be working. See #365869 (review) where the change is successfully tested in a VM.

@bjornfor bjornfor merged commit a034e02 into release-24.11 Dec 19, 2024
30 of 31 checks passed
@bjornfor bjornfor deleted the backport-365869-to-release-24.11 branch December 19, 2024 15:15
@jtojnar
Copy link
Member

jtojnar commented Dec 19, 2024

Probably not supposed to run that way but it means that glib is missing from gi_typelib_path. It is probably not triggered in regular usage because GLib is probably inherited from the ¿gnome-shell process? that launches the preferences programs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants