-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rwalk: init at 0.8.7 #366586
base: master
Are you sure you want to change the base?
rwalk: init at 0.8.7 #366586
Conversation
pkgs/by-name/rw/rwalk/package.nix
Outdated
src = fetchFromGitHub { | ||
owner = "cestef"; | ||
repo = "rwalk"; | ||
rev = "v${version}"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tag = "v${version}";
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idk why but the ci is showing error. I'll be working on that issue tomorrow if it's from my end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that now you have changed to a tag, the {src.rev}
is no longer defined on line 49, and you'd need to use a tagged link to the release notes too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hell yeah, could you verify now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ofborg runs again automatically once you've changed the PR. Should have the results within the day
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think before it was failing on one of the GHA evals though, and that passed now, so it looks like it'll be fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 🎉
@pwnwriter Looks good to me, but I don't have commit access, and don't maintain a similar package, so it doesn't make sense for me to leave an approving review. Once the tests have passed, my suggestion to get it merged would be to find someone who has merged a rust tool comparable to this into |
Description of changes
A blazingly fast web directory scanner written in Rust
https://github.com/cestef/rwalk
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.