Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upbound: 0.36.1 -> 0.36.2, upbound-main: 0.37.0-0.rc.0.38.g797e121 ->… #366766

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jljox
Copy link
Contributor

@jljox jljox commented Dec 20, 2024

upbound: 0.36.1 -> 0.36.2, upbound-main: 0.37.0-0.rc.0.38.g797e121 -> upbound-main-0.37.0-0.rc.0.48.g9853a74

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@jljox jljox force-pushed the upbound-0.36.1-0.36.2-upbound-main-0.37.0-0.rc.0.38.g797e121-0.37.0-0.rc.0.43.g0edf595 branch from e5089b6 to afd3041 Compare December 20, 2024 10:32
@jljox jljox force-pushed the upbound-0.36.1-0.36.2-upbound-main-0.37.0-0.rc.0.38.g797e121-0.37.0-0.rc.0.43.g0edf595 branch from afd3041 to 60810fe Compare December 20, 2024 10:36
@jljox jljox requested a review from Scrumplex December 20, 2024 10:46
@ofborg ofborg bot requested a review from lucperkins December 20, 2024 21:03
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Dec 20, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be a big ask, but what do you think about rewriting this script in something like Python? That way, we can generate the JSON without relying on Nix at all and have generally more readable code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
I have done it in Haskell.

@jljox jljox force-pushed the upbound-0.36.1-0.36.2-upbound-main-0.37.0-0.rc.0.38.g797e121-0.37.0-0.rc.0.43.g0edf595 branch 6 times, most recently from d71a64c to 0b3a4d9 Compare January 7, 2025 15:23
@jljox jljox force-pushed the upbound-0.36.1-0.36.2-upbound-main-0.37.0-0.rc.0.38.g797e121-0.37.0-0.rc.0.43.g0edf595 branch from 0b3a4d9 to df20eae Compare January 7, 2025 15:40
@jljox jljox requested a review from Scrumplex January 9, 2025 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants