Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[staging-next] python313Packages.pillow-heif: remove -Werror #366771

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

paparodeo
Copy link
Contributor

clang fails due a warning switching -Ofast -> -O3 while building with -Werror.

https://hydra.nixos.org/build/282270509

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

clang fails due a warning switching `-Ofast` -> `-O3` while building
with `-Werror`.
@ofborg ofborg bot requested a review from dali99 December 20, 2024 21:00
@mweinelt mweinelt merged commit b970654 into NixOS:staging-next Dec 20, 2024
39 of 41 checks passed
@paparodeo paparodeo deleted the pillow-heif-werror branch December 20, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants