[Backport release-24.11]: String fixes #366919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piegamesde
force-pushed
the
string-fixes
branch
from
f9f0c60 to
12a4cb7
Compare
(cherry picked from commit 772ad02)
(cherry picked from commit 69f9bc3)
(cherry picked from commit 62fcc79)
(cherry picked from commit 50a57d5)
(cherry picked from commit 8b344a7)
(cherry picked from commit 0bf6262)
(cherry picked from commit f969847)
(cherry picked from commit 70e7ca4)
(cherry picked from commit bd29629)
(cherry picked from commit 6d81529)
(cherry picked from commit e044fed)
(cherry picked from commit 160f865)
(cherry picked from commit 591861f)
piegamesde
force-pushed
the
string-fixes
branch
from
12a4cb7 to
8f43aca
Compare
adamcstephens
approved these changes
Dec 21, 2024
wegank
added
the
12.approvals: 1
pineapplehunter
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #365186
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.