Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.chime: init at 0-unstable-2023-03-06 #367491

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

poperigby
Copy link
Contributor

Added chime

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@lucasew
Copy link
Contributor

lucasew commented Dec 23, 2024

Please rename the PR and commit to python3Packages.chime: init at unstable-2023-03-06 as explained in CONTRIBUTING.

@poperigby poperigby changed the title init: chime unstable-2023-03-06 python3Packages.chime: init at 0-unstable-2023-03-06 Dec 23, 2024
@poperigby
Copy link
Contributor Author

Please rename the PR and commit to python3Packages.chime: init at unstable-2023-03-06 as explained in CONTRIBUTING.

Sorry about that. Should be fixed.

@poperigby poperigby requested a review from lucasew December 23, 2024 17:55
@lucasew
Copy link
Contributor

lucasew commented Dec 23, 2024

Please rename the PR and commit to python3Packages.chime: init at unstable-2023-03-06 as explained in CONTRIBUTING.

Sorry about that. Should be fixed.

No need to be sorry. The best thing of code review heavy projects is that you don't need to worry so much because there will be more eyes on the code to find issues. I may not have a deep understanding about the domain of this package but I can unblock the people that has by solving, or guiding to solve, the most common issues.

@lucasew
Copy link
Contributor

lucasew commented Dec 23, 2024

BTW what a cool piece of software you got here.

Just tested it locally on my x86_64-linux machine and works very well.

I'm wondering if I could bring the sounds of Windows XP there 🤔.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes labels Dec 23, 2024
@poperigby
Copy link
Contributor Author

BTW what a cool piece of software you got here.

Just tested it locally on my x86_64-linux machine and works very well.

I'm wondering if I could bring the sounds of Windows XP there 🤔.

Yeah, it is cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants