-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.chime: init at 0-unstable-2023-03-06 #367491
base: master
Are you sure you want to change the base?
Conversation
Please rename the PR and commit to |
Sorry about that. Should be fixed. |
No need to be sorry. The best thing of code review heavy projects is that you don't need to worry so much because there will be more eyes on the code to find issues. I may not have a deep understanding about the domain of this package but I can unblock the people that has by solving, or guiding to solve, the most common issues. |
BTW what a cool piece of software you got here. Just tested it locally on my x86_64-linux machine and works very well. I'm wondering if I could bring the sounds of Windows XP there 🤔. |
Yeah, it is cool! |
Added chime
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.