nixos/paperless: mirror upstream admin user creation more closely #367545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
SuperSandro2000
force-pushed
the
paperless-admin-user
branch
from
b6fb18e to
860c359
Compare
github-actions
bot
added
10.rebuild-darwin: 0
SuperSandro2000
force-pushed
the
paperless-admin-user
branch
from
860c359 to
231ccbf
Compare
Atemu
reviewed
Dec 23, 2024
| ${cfg.package}/bin/paperless-ngx manage_superuser | ||
| echo "$superuserState" > "$superuserStateFile" | ||
|
|
||
| if ${if cfg.passwordFile != null then "true" else "false"} || [[ -n $PAPERLESS_ADMIN_PASSWORD ]]; then |
Comment on lines
+333
to
+336
| if [[ -e $CREDENTIALS_DIRECTORY/PAPERLESS_ADMIN_PASSWORD ]]; then | ||
| PAPERLESS_ADMIN_PASSWORD=$(cat "$CREDENTIALS_DIRECTORY/PAPERLESS_ADMIN_PASSWORD") | ||
| export PAPERLESS_ADMIN_PASSWORD | ||
| fi |
There was a problem hiding this comment.
I assume this check exists to not override the password env var unconditionally?
It'd be great to explain a little (ideally in the commit message) how exactly your patch fixes the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #249767
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.