gltron: fix the build against gcc-14 #367678
Merged
+12
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
10.rebuild-darwin: 0
There was a problem hiding this comment.
Looks good, should we send the patches upstream? Even if they don't get merged, other distros could at least use it.
Without the change `gltron` fails to build as:
./src/gltron.c: In function 'main':
./src/gltron.c:13:30: error: passing argument 2 of 'initSubsystems' from incompatible pointer type [-Wincompatible-pointer-types]
13 | initSubsystems(argc, argv);
| ^~~~
| |
| char **
trofi
force-pushed
the
gltron-gcc-14-fix
branch
from
6a767e8 to
1a13741
Compare
Sounds good. Filed https://sourceforge.net/p/gltron/patches/7/ and pointed fetcher to it. |
|
philiptaron
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
I desire a future where a bot comes along and archives all these patches and rewrites the derivation to use the canonical archive source so that I don't get conniptions about whether SourceForge URLs are trustworthy or not.
But that future doesn't exist. Yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the change
gltronfails to build as:Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.