Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wol: fix build with GCC 14 #368069

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

wol: fix build with GCC 14 #368069

wants to merge 1 commit into from

Conversation

jcaesar
Copy link
Contributor

@jcaesar jcaesar commented Dec 25, 2024

GCC 14 (#356812) breaks this package due to various badly written autotools scripts:

  • failed checks that shouldn't, e.g. checking for working malloc... no
  • ignored checks that would otherwise have made wol correctly include headers (unconditinally setting to 0 after conditionally setting to 1)

(I wouldn't know how to upstream the patch to sf and the last commit is from 2004.)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review


x86_64-linux

✅ 1 package built:
  • wol

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 25, 2024
Copy link
Contributor

@paparodeo paparodeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://gitlab.alpinelinux.org/alpine/aports/-/tree/master/testing/wol

looks like getline.m4 needs to include stdlib too

@jcaesar
Copy link
Contributor Author

jcaesar commented Dec 25, 2024

@paparodeo Ty. Applied.

(I do wonder if what is more sensible, replacing return by exit (since it's the exit that errors), or including stdlib.h (because not doing that also gives a warning for malloc). But that's really a question for someone maintaining wol, for distros either is good enough.)

@ofborg ofborg bot requested a review from makefu December 25, 2024 15:29
@paparodeo
Copy link
Contributor

@paparodeo Ty. Applied.

(I do wonder if what is more sensible, replacing return by exit (since it's the exit that errors), or including stdlib.h (because not doing that also gives a warning for malloc). But that's really a question for someone maintaining wol, for distros either is good enough.)

for others I usually replace exit with return but adding stdlib.h is fine too. I don't think it matters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants