Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xygrib: unpin proj_7 #373368

Merged
merged 1 commit into from
Jan 18, 2025
Merged

xygrib: unpin proj_7 #373368

merged 1 commit into from
Jan 18, 2025

Conversation

paparodeo
Copy link
Contributor

the current unstable version of xygrib builds fine on proj

opengribs/XyGrib#289

proj_7 is broken on staging-next: https://hydra.nixos.org/build/284643562 and this is one of the 2 consumers.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

the current unstable version of xygrib builds fine on proj

`https://github.com/opengribs/XyGrib/pull/289`
@paparodeo
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 373368


x86_64-linux

✅ 1 package built:
  • xygrib

@paparodeo
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 373368


aarch64-darwin

✅ 1 package built:
  • xygrib

@paparodeo
Copy link
Contributor Author

cc maintainer: @johannesloetzsch

@FliegendeWurst
Copy link
Member

Will merge in a few days unless the maintainer objects.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 14, 2025
@FliegendeWurst FliegendeWurst merged commit 19a9bbe into NixOS:master Jan 18, 2025
26 of 28 checks passed
@paparodeo paparodeo deleted the xygrib-unpin-proj branch January 18, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants