[FIX] crm_lead_vat: fix onchange error

crm_lead_vat/__openerp__.py

@@ -4,7 +4,7 @@
 {
     "name": "VAT in leads",
     "summary": "Add VAT field to leads",
-    "version": "8.0.1.1.0",
+    "version": "8.0.1.1.1",
     "category": "Customer Relationship Management",
     "website": "http://www.antiun.com",
     "author": "Antiun Ingeniería S.L., Odoo Community Association (OCA)",

crm_lead_vat/i18n/bg.po

@@ -1,7 +1,7 @@
 # Translation of Odoo Server.
 # This file contains the translation of the following modules:
 # * crm_lead_vat
-# 
+#
 # Translators:
 msgid ""
 msgstr ""
@@ -10,11 +10,12 @@ msgstr ""
 "POT-Creation-Date: 2016-11-02 14:15+0000\n"
 "PO-Revision-Date: 2016-03-10 18:53+0000\n"
 "Last-Translator: <>\n"
-"Language-Team: Bulgarian (http://www.transifex.com/oca/OCA-crm-8-0/language/bg/)\n"
+"Language-Team: Bulgarian (http://www.transifex.com/oca/OCA-crm-8-0/language/"
+"bg/)\n"
+"Language: bg\n"
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: \n"
-"Language: bg\n"
 "Plural-Forms: nplurals=2; plural=(n != 1);\n"
 
 #. module: crm_lead_vat
@@ -29,6 +30,5 @@ msgstr ""
 
 #. module: crm_lead_vat
 #: help:crm.lead,vat:0
-msgid ""
-"Tax Identification Number. The first 2 characters are the country code."
+msgid "Tax Identification Number. The first 2 characters are the country code."
 msgstr ""

crm_lead_vat/i18n/crm_lead_vat.pot

@@ -6,8 +6,6 @@ msgid ""
 msgstr ""
 "Project-Id-Version: Odoo Server 8.0\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2015-10-30 16:00+0000\n"
-"PO-Revision-Date: 2015-10-30 16:00+0000\n"
 "Last-Translator: <>\n"
 "Language-Team: \n"
 "MIME-Version: 1.0\n"
@@ -20,3 +18,13 @@ msgstr ""
 msgid "Lead/Opportunity"
 msgstr ""
 
+#. module: crm_lead_vat
+#: field:crm.lead,vat:0
+msgid "TIN"
+msgstr ""
+
+#. module: crm_lead_vat
+#: help:crm.lead,vat:0
+msgid "Tax Identification Number. The first 2 characters are the country code."
+msgstr ""
+

crm_lead_vat/i18n/de.po

@@ -1,7 +1,7 @@
 # Translation of Odoo Server.
 # This file contains the translation of the following modules:
 # * crm_lead_vat
-# 
+#
 # Translators:
 # Rudolf Schnapka <[email protected]>, 2017
 msgid ""
@@ -11,11 +11,12 @@ msgstr ""
 "POT-Creation-Date: 2017-03-28 02:26+0000\n"
 "PO-Revision-Date: 2017-04-11 14:58+0000\n"
 "Last-Translator: Rudolf Schnapka <[email protected]>\n"
-"Language-Team: German (http://www.transifex.com/oca/OCA-crm-8-0/language/de/)\n"
+"Language-Team: German (http://www.transifex.com/oca/OCA-crm-8-0/language/"
+"de/)\n"
+"Language: de\n"
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: \n"
-"Language: de\n"
 "Plural-Forms: nplurals=2; plural=(n != 1);\n"
 
 #. module: crm_lead_vat
@@ -30,6 +31,7 @@ msgstr "USt-ID:"
 
 #. module: crm_lead_vat
 #: help:crm.lead,vat:0
-msgid ""
-"Tax Identification Number. The first 2 characters are the country code."
-msgstr "Steueridentifikationsnummer. Die ersten zwei Zeichen stellen den Länderschlüssel dar."
+msgid "Tax Identification Number. The first 2 characters are the country code."
+msgstr ""
+"Steueridentifikationsnummer. Die ersten zwei Zeichen stellen den "
+"Länderschlüssel dar."

crm_lead_vat/i18n/es.po

@@ -1,7 +1,7 @@
 # Translation of Odoo Server.
 # This file contains the translation of the following modules:
 # * crm_lead_vat
-# 
+#
 # Translators:
 # Carles Antoli <[email protected]>, 2016
 msgid ""
@@ -11,11 +11,12 @@ msgstr ""
 "POT-Creation-Date: 2016-04-14 03:55+0000\n"
 "PO-Revision-Date: 2016-04-07 15:49+0000\n"
 "Last-Translator: Carles Antoli <[email protected]>\n"
-"Language-Team: Spanish (http://www.transifex.com/oca/OCA-crm-8-0/language/es/)\n"
+"Language-Team: Spanish (http://www.transifex.com/oca/OCA-crm-8-0/language/"
+"es/)\n"
+"Language: es\n"
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: \n"
-"Language: es\n"
 "Plural-Forms: nplurals=2; plural=(n != 1);\n"
 
 #. module: crm_lead_vat
@@ -30,6 +31,7 @@ msgstr "NIF"
 
 #. module: crm_lead_vat
 #: help:crm.lead,vat:0
-msgid ""
-"Tax Identification Number. The first 2 characters are the country code."
-msgstr "Número de identificación fiscal. Los 2 primeros caracteres son el código del país."
+msgid "Tax Identification Number. The first 2 characters are the country code."
+msgstr ""
+"Número de identificación fiscal. Los 2 primeros caracteres son el código del "
+"país."

crm_lead_vat/i18n/fr.po

@@ -1,7 +1,7 @@
 # Translation of Odoo Server.
 # This file contains the translation of the following modules:
 # * crm_lead_vat
-# 
+#
 # Translators:
 msgid ""
 msgstr ""
@@ -10,11 +10,12 @@ msgstr ""
 "POT-Creation-Date: 2016-03-10 18:52+0000\n"
 "PO-Revision-Date: 2016-03-10 18:53+0000\n"
 "Last-Translator: <>\n"
-"Language-Team: French (http://www.transifex.com/oca/OCA-crm-8-0/language/fr/)\n"
+"Language-Team: French (http://www.transifex.com/oca/OCA-crm-8-0/language/"
+"fr/)\n"
+"Language: fr\n"
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: \n"
-"Language: fr\n"
 "Plural-Forms: nplurals=2; plural=(n > 1);\n"
 
 #. module: crm_lead_vat
@@ -29,6 +30,5 @@ msgstr ""
 
 #. module: crm_lead_vat
 #: help:crm.lead,vat:0
-msgid ""
-"Tax Identification Number. The first 2 characters are the country code."
+msgid "Tax Identification Number. The first 2 characters are the country code."
 msgstr ""

crm_lead_vat/i18n/hr.po

@@ -1,7 +1,7 @@
 # Translation of Odoo Server.
 # This file contains the translation of the following modules:
 # * crm_lead_vat
-# 
+#
 # Translators:
 # Ana-Maria Olujić <[email protected]>, 2016
 msgid ""
@@ -11,12 +11,14 @@ msgstr ""
 "POT-Creation-Date: 2016-08-15 00:49+0000\n"
 "PO-Revision-Date: 2016-08-19 13:47+0000\n"
 "Last-Translator: Ana-Maria Olujić <[email protected]>\n"
-"Language-Team: Croatian (http://www.transifex.com/oca/OCA-crm-8-0/language/hr/)\n"
+"Language-Team: Croatian (http://www.transifex.com/oca/OCA-crm-8-0/language/"
+"hr/)\n"
+"Language: hr\n"
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: \n"
-"Language: hr\n"
-"Plural-Forms: nplurals=3; plural=n%10==1 && n%100!=11 ? 0 : n%10>=2 && n%10<=4 && (n%100<10 || n%100>=20) ? 1 : 2;\n"
+"Plural-Forms: nplurals=3; plural=n%10==1 && n%100!=11 ? 0 : n%10>=2 && n"
+"%10<=4 && (n%100<10 || n%100>=20) ? 1 : 2;\n"
 
 #. module: crm_lead_vat
 #: model:ir.model,name:crm_lead_vat.model_crm_lead
@@ -30,6 +32,5 @@ msgstr "OIB"
 
 #. module: crm_lead_vat
 #: help:crm.lead,vat:0
-msgid ""
-"Tax Identification Number. The first 2 characters are the country code."
+msgid "Tax Identification Number. The first 2 characters are the country code."
 msgstr "OIB. Prva 2 slova su oznaka države."

crm_lead_vat/i18n/it.po

@@ -1,7 +1,7 @@
 # Translation of Odoo Server.
 # This file contains the translation of the following modules:
 # * crm_lead_vat
-# 
+#
 # Translators:
 msgid ""
 msgstr ""
@@ -10,11 +10,12 @@ msgstr ""
 "POT-Creation-Date: 2016-04-16 11:11+0000\n"
 "PO-Revision-Date: 2016-03-10 18:53+0000\n"
 "Last-Translator: <>\n"
-"Language-Team: Italian (http://www.transifex.com/oca/OCA-crm-8-0/language/it/)\n"
+"Language-Team: Italian (http://www.transifex.com/oca/OCA-crm-8-0/language/"
+"it/)\n"
+"Language: it\n"
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: \n"
-"Language: it\n"
 "Plural-Forms: nplurals=2; plural=(n != 1);\n"
 
 #. module: crm_lead_vat
@@ -29,6 +30,5 @@ msgstr ""
 
 #. module: crm_lead_vat
 #: help:crm.lead,vat:0
-msgid ""
-"Tax Identification Number. The first 2 characters are the country code."
+msgid "Tax Identification Number. The first 2 characters are the country code."
 msgstr ""

crm_lead_vat/i18n/pt_BR.po

@@ -1,7 +1,7 @@
 # Translation of Odoo Server.
 # This file contains the translation of the following modules:
 # * crm_lead_vat
-# 
+#
 # Translators:
 msgid ""
 msgstr ""
@@ -10,11 +10,12 @@ msgstr ""
 "POT-Creation-Date: 2016-03-26 09:38+0000\n"
 "PO-Revision-Date: 2016-03-10 18:53+0000\n"
 "Last-Translator: <>\n"
-"Language-Team: Portuguese (Brazil) (http://www.transifex.com/oca/OCA-crm-8-0/language/pt_BR/)\n"
+"Language-Team: Portuguese (Brazil) (http://www.transifex.com/oca/OCA-crm-8-0/"
+"language/pt_BR/)\n"
+"Language: pt_BR\n"
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: \n"
-"Language: pt_BR\n"
 "Plural-Forms: nplurals=2; plural=(n > 1);\n"
 
 #. module: crm_lead_vat
@@ -29,6 +30,5 @@ msgstr ""
 
 #. module: crm_lead_vat
 #: help:crm.lead,vat:0
-msgid ""
-"Tax Identification Number. The first 2 characters are the country code."
+msgid "Tax Identification Number. The first 2 characters are the country code."
 msgstr ""

crm_lead_vat/i18n/sk.po

@@ -1,7 +1,7 @@
 # Translation of Odoo Server.
 # This file contains the translation of the following modules:
 # * crm_lead_vat
-# 
+#
 # Translators:
 msgid ""
 msgstr ""
@@ -10,11 +10,12 @@ msgstr ""
 "POT-Creation-Date: 2016-12-17 01:26+0000\n"
 "PO-Revision-Date: 2016-03-10 18:53+0000\n"
 "Last-Translator: <>\n"
-"Language-Team: Slovak (http://www.transifex.com/oca/OCA-crm-8-0/language/sk/)\n"
+"Language-Team: Slovak (http://www.transifex.com/oca/OCA-crm-8-0/language/"
+"sk/)\n"
+"Language: sk\n"
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: \n"
-"Language: sk\n"
 "Plural-Forms: nplurals=3; plural=(n==1) ? 0 : (n>=2 && n<=4) ? 1 : 2;\n"
 
 #. module: crm_lead_vat
@@ -29,6 +30,5 @@ msgstr ""
 
 #. module: crm_lead_vat
 #: help:crm.lead,vat:0
-msgid ""
-"Tax Identification Number. The first 2 characters are the country code."
+msgid "Tax Identification Number. The first 2 characters are the country code."
 msgstr ""

crm_lead_vat/i18n/sl.po

@@ -1,7 +1,7 @@
 # Translation of Odoo Server.
 # This file contains the translation of the following modules:
 # * crm_lead_vat
-# 
+#
 # Translators:
 # Matjaž Mozetič <[email protected]>, 2016
 msgid ""
@@ -11,12 +11,14 @@ msgstr ""
 "POT-Creation-Date: 2016-03-10 18:52+0000\n"
 "PO-Revision-Date: 2016-03-11 10:47+0000\n"
 "Last-Translator: Matjaž Mozetič <[email protected]>\n"
-"Language-Team: Slovenian (http://www.transifex.com/oca/OCA-crm-8-0/language/sl/)\n"
+"Language-Team: Slovenian (http://www.transifex.com/oca/OCA-crm-8-0/language/"
+"sl/)\n"
+"Language: sl\n"
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: \n"
-"Language: sl\n"
-"Plural-Forms: nplurals=4; plural=(n%100==1 ? 0 : n%100==2 ? 1 : n%100==3 || n%100==4 ? 2 : 3);\n"
+"Plural-Forms: nplurals=4; plural=(n%100==1 ? 0 : n%100==2 ? 1 : n%100==3 || n"
+"%100==4 ? 2 : 3);\n"
 
 #. module: crm_lead_vat
 #: model:ir.model,name:crm_lead_vat.model_crm_lead
@@ -30,6 +32,5 @@ msgstr "ID za DDV"
 
 #. module: crm_lead_vat
 #: help:crm.lead,vat:0
-msgid ""
-"Tax Identification Number. The first 2 characters are the country code."
+msgid "Tax Identification Number. The first 2 characters are the country code."
 msgstr "Davčna identifikacijska številka. Prva 2 znaka sta črki kode države."

crm_lead_vat/i18n/zh_CN.po

@@ -1,7 +1,7 @@
 # Translation of Odoo Server.
 # This file contains the translation of the following modules:
 # * crm_lead_vat
-# 
+#
 # Translators:
 msgid ""
 msgstr ""
@@ -10,11 +10,12 @@ msgstr ""
 "POT-Creation-Date: 2017-02-25 01:51+0000\n"
 "PO-Revision-Date: 2016-03-10 18:53+0000\n"
 "Last-Translator: <>\n"
-"Language-Team: Chinese (China) (http://www.transifex.com/oca/OCA-crm-8-0/language/zh_CN/)\n"
+"Language-Team: Chinese (China) (http://www.transifex.com/oca/OCA-crm-8-0/"
+"language/zh_CN/)\n"
+"Language: zh_CN\n"
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: \n"
-"Language: zh_CN\n"
 "Plural-Forms: nplurals=1; plural=0;\n"
 
 #. module: crm_lead_vat
@@ -29,6 +30,5 @@ msgstr ""
 
 #. module: crm_lead_vat
 #: help:crm.lead,vat:0
-msgid ""
-"Tax Identification Number. The first 2 characters are the country code."
+msgid "Tax Identification Number. The first 2 characters are the country code."
 msgstr ""

crm_lead_vat/models.py

@@ -22,9 +22,10 @@ def _lead_create_contact(self, lead, name, is_company, parent_id=False):
     def on_change_partner_id(self, partner_id):
         """Recover VAT from partner if available."""
         result = super(Lead, self).on_change_partner_id(partner_id)
-
-        if result.get("value"):
-            if self.partner_id and self.partner_id.vat:
-                result["value"]["vat"] = self.partner_id.vat
-
+        if not partner_id:
+            return result
+        partner = self.env['res.partner'].browse(partner_id)
+        if partner.vat:
+            value = result.setdefault('value', {})
+            value['vat'] = partner.vat
         return result

crm_lead_vat/tests/test_lead.py

@@ -24,6 +24,8 @@ def test_transfered_values(self):
     def test_onchange_partner_id(self):
         """Lead gets VAT from partner when linked to it."""
         self.partner.vat = self.test_field
+        result = self.lead.on_change_partner_id(self.lead.partner_id.id)
+        self.assertNotIn("vat", result["value"])
         self.lead.partner_id = self.partner
-        result = self.lead.on_change_partner_id(self.partner.id)
+        result = self.lead.on_change_partner_id(self.lead.partner_id.id)
         self.assertEqual(result["value"]["vat"], self.test_field)