[18.0][MIG] hr_expense_payment: Migration to 18.0 #280
Conversation
Currently translated at 100.0% (6 of 6 strings) Translation: hr-expense-16.0/hr-expense-16.0-hr_expense_payment Translate-URL: https://translation.odoo-community.org/projects/hr-expense-16-0/hr-expense-16-0-hr_expense_payment/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-expense-16.0/hr-expense-16.0-hr_expense_payment Translate-URL: https://translation.odoo-community.org/projects/hr-expense-16-0/hr-expense-16-0-hr_expense_payment/
lef-adhoc
force-pushed
the
18.0-mig-hr_expense_payment
branch
from
df98435 to
6660847
Compare
|
@pedrobaeza Hi! Can you review it please? Thanks! |
|
/ocabot migration hr_expense_payment Sorry, not using this module. |
|
@pedrobaez Don't be sorry! Thank you very much for your time! |
|
LGTM |
|
This PR has the |
|
Hi @Saran440 could you please check this? Thanks in advance |
|
Hi @pedrobaeza, could you please check this pr? thanks! |
|
A PSC must review this PR. |
|
@pedrobaeza I tagged you since you are in this list: https://oca.github.io/repo-maintainer-conf/teams.html#human-resources-maintainers |
|
Yeah, but as said, I'm not using this module, so I can't validate that is correct. Their authors/contributors can also check. |
|
Oops, I'm sorry @pedrobaeza , I missed your message 2 weeks ago. My bad. |
| def _create_payment_vals_from_batch(self, batch_result): | ||
| payment_vals = super()._create_payment_vals_from_batch(batch_result) | ||
| expense_sheet_ids = self._context.get("expense_sheet_ids", False) | ||
| if expense_sheet_ids: |
There was a problem hiding this comment.
| if expense_sheet_ids: | |
| if expense_sheet_ids: | |
| moves = self.env["account.move"].browse(batch_result["lines"].move_id.ids) | |
| payment_vals.update(expense_sheet_ids=moves.expense_sheet_id.ids) |
reduct browse and filter function.
|
Hi @Saran440, |
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 6a3bf00. Thanks a lot for contributing to OCA. ❤️ |
No description provided.