-
-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][FIX] stock_picking_group_by_partner_by_carrier: merged procurement group should not be linked to the original sales order #1789
base: 16.0
Are you sure you want to change the base?
Conversation
… sale link When a merged procurement group is created, it should not be linked to the original sales order. Linking it would cause any moves manually added to the delivery picking to be associated with that sales order. This commit reproduce the bug and show the manual add of the move impact the sale order
cc/ @rousseldenis , @lmignon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this FIX. Indeed, without this a merged procurement could introduce hard to understand unexpected behaviour. LGTM (Code review)
This PR has the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good morning,
I have reviewed this FIX at a functional level and this LGTM👍
…ment group should not be linked to the original sales order
79640aa
to
4fe0732
Compare
When a merged procurement group is created, it should not be linked to the original sales order. Linking it would cause any moves manually added to the delivery picking to be associated with that sales order.
The first commit reproduce the bug and show how the manual add of a move to the picking impact the sale order.