Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] stock_picking_group_by_partner_by_carrier: merged procurement group should not be linked to the original sales order #1789

Open
wants to merge 2 commits into
base: 16.0
Choose a base branch
from

Conversation

sbejaoui
Copy link
Contributor

When a merged procurement group is created, it should not be linked to the original sales order. Linking it would cause any moves manually added to the delivery picking to be associated with that sales order.

The first commit reproduce the bug and show how the manual add of a move to the picking impact the sale order.

… sale link

When a merged procurement group is created, it should not be linked to the
original sales order. Linking it would cause any moves manually added to the
delivery picking to be associated with that sales order.

This commit reproduce the bug and show the manual add of the move impact the sale order
@sbejaoui sbejaoui changed the title [IMP] stock_picking_group_by_partner_by_carrier: merged procurement group should not be linked to the original sales order [16.0][FIX] stock_picking_group_by_partner_by_carrier: merged procurement group should not be linked to the original sales order Dec 11, 2024
@sbejaoui
Copy link
Contributor Author

cc/ @rousseldenis , @lmignon

Copy link
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this FIX. Indeed, without this a merged procurement could introduce hard to understand unexpected behaviour. LGTM (Code review)

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link

@lauradiaz22 lauradiaz22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good morning,
I have reviewed this FIX at a functional level and this LGTM👍

…ment group should not be linked to the original sales order
@sbejaoui sbejaoui force-pushed the 16.0-stock_picking_group_by_partner_by_carrier-sbj branch from 79640aa to 4fe0732 Compare December 31, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants