[18.0][MIG] delivery_carrier_warehouse: Migration to 18.0 #963
Conversation
Currently translated at 100.0% (7 of 7 strings) Translation: wms-14.0/wms-14.0-delivery_carrier_warehouse Translate-URL: https://translation.odoo-community.org/projects/wms-14-0/wms-14-0-delivery_carrier_warehouse/es_AR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: wms-15.0/wms-15.0-delivery_carrier_warehouse Translate-URL: https://translation.odoo-community.org/projects/wms-15-0/wms-15-0-delivery_carrier_warehouse/
Currently translated at 100.0% (4 of 4 strings) Translation: wms-16.0/wms-16.0-delivery_carrier_warehouse Translate-URL: https://translation.odoo-community.org/projects/wms-16-0/wms-16-0-delivery_carrier_warehouse/it/
To silence a deprecation warning
| delivery_carrier_id = fields.Many2one( | ||
| "delivery.carrier", | ||
| string="Delivery Method", | ||
| help="Default delivery method used in sales orders. Will be applied " |
There was a problem hiding this comment.
Could you add check_company=True here?
| <field name="partner_id" position="after"> | ||
| <field | ||
| name="delivery_carrier_id" | ||
| domain="[('company_id', 'in', (False, company_id))]" |
There was a problem hiding this comment.
Normally, if you use check_company=True on the field attribute, the domain is automatically set by the ORM
chaule97
force-pushed
the
18.0-mig-delivery_carrier_warehouse
branch
from
56a5456 to
9de6366
Compare
| from odoo.tests.common import Form, TransactionCase | ||
| from odoo.tests import Form | ||
|
|
||
| from odoo.addons.base.tests.common import BaseCommon | ||
|
|
||
| class TestSaleDeliveryCarrierPreference(TransactionCase): | ||
|
|
||
| class TestSaleDeliveryCarrierPreference(BaseCommon): |
There was a problem hiding this comment.
Why you changed TransactionCase to BaseCommon ?
The class name TestSaleDeliveryCarrierPreference looks like a wrong copy/paste
There was a problem hiding this comment.
Why you changed TransactionCase to BaseCommon ?
BaseCommon inherrite TransactionCase, and we don't need to write cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True))
chaule97
force-pushed
the
18.0-mig-delivery_carrier_warehouse
branch
from
9de6366 to
b40b1f9
Compare
|
/ocabot migration delivery_carrier_warehouse |
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 21e0aea. Thanks a lot for contributing to OCA. ❤️ |
deliverymodule in version 15.0 depends onsaleinstead ofsale_stock, I need to update thedelivery_carrier_warehousemodule to depend onstock_deliveryinstead ofdelivery.