Drop @throws

OG-C · Nov 6, 2019 · 2b50e85 · 2b50e85
1 parent 2aed3e4
commit 2b50e85
Show file tree

Hide file tree

Showing 7 changed files with 1 addition and 15 deletions.
diff --git a/app/src/main/java/com/github/shadowsocks/BaseService.kt b/app/src/main/java/com/github/shadowsocks/BaseService.kt
@@ -149,7 +149,6 @@ abstract class BaseService : Service()
 		}
 	}
 
-	@Throws(NameNotResolvedException::class, NullConnectionException::class)
 	fun connect()
 	{
 		if (profile == null) return
@@ -163,7 +162,6 @@ abstract class BaseService : Service()
 			val client = OkHttpClient.Builder()
 				.dns(object : Dns
 					 {
-						 @Throws(UnknownHostException::class)
 						 override fun lookup(hostname: String): List<InetAddress>
 						 {
 							 val ip = Utils.resolve(hostname, false)

diff --git a/app/src/main/java/com/github/shadowsocks/BaseVpnService.kt b/app/src/main/java/com/github/shadowsocks/BaseVpnService.kt
@@ -177,7 +177,6 @@ abstract class BaseVpnService : VpnService()
 		}
 	}
 
-	@Throws(NameNotResolvedException::class, NullConnectionException::class)
 	open fun connect()
 	{
 		if (profile == null) return
@@ -191,7 +190,6 @@ abstract class BaseVpnService : VpnService()
 			val client = OkHttpClient.Builder()
 				.dns(object : Dns
 					 {
-						 @Throws(UnknownHostException::class)
 						 override fun lookup(hostname: String): List<InetAddress>
 						 {
 							 val ip = Utils.resolve(hostname, false)

diff --git a/app/src/main/java/com/github/shadowsocks/GuardedProcess.kt b/app/src/main/java/com/github/shadowsocks/GuardedProcess.kt
@@ -13,7 +13,6 @@ class GuardedProcess(private val cmd: List<String>)
 	private var process: Process? = null
 	private var isRestart = false
 
-	@Throws(InterruptedException::class)
 	@JvmOverloads
 	fun start(onRestartCallback: (() -> Boolean)? = null): GuardedProcess
 	{

diff --git a/app/src/main/java/com/github/shadowsocks/ShadowsocksTileService.kt b/app/src/main/java/com/github/shadowsocks/ShadowsocksTileService.kt
@@ -23,7 +23,6 @@ class ShadowsocksTileService : TileService()
 		{
 		}
 
-		@Throws(RemoteException::class)
 		override fun stateChanged(state: Int, profileName: String?, msg: String?)
 		{
 			val tile = qsTile

diff --git a/app/src/main/java/com/github/shadowsocks/ShadowsocksVpnService.kt b/app/src/main/java/com/github/shadowsocks/ShadowsocksVpnService.kt
@@ -136,7 +136,6 @@ class ShadowsocksVpnService : BaseVpnService()
 		super.startRunner(profile)
 	}
 
-	@Throws(NameNotResolvedException::class)
 	override fun connect()
 	{
 		super.connect()
@@ -209,7 +208,6 @@ class ShadowsocksVpnService : BaseVpnService()
 	/**
 	 * Called when the activity is first created.
 	 */
-	@Throws(Exception::class)
 	fun handleConnection()
 	{
 		if (!sendFd(startVpn()))

diff --git a/app/src/main/java/com/github/shadowsocks/network/request/RequestHelper.kt b/app/src/main/java/com/github/shadowsocks/network/request/RequestHelper.kt
@@ -82,10 +82,8 @@ private constructor(builder: OkHttpClient.Builder? = null)
 	 *
 	 * @param request request object
 	 * @return response object
-	 * @throws IOException request exception
 	 */
-	@Throws(IOException::class)
-	fun requestByThread(request: Request): Response
+	private fun requestByThread(request: Request): Response
 	{
 		return mClient!!.newCall(request)
 			.execute()

diff --git a/app/src/main/java/com/github/shadowsocks/utils/IOUtils.kt b/app/src/main/java/com/github/shadowsocks/utils/IOUtils.kt
@@ -13,9 +13,7 @@ object IOUtils
 	 *
 	 * @param inputStream  input stream
 	 * @param out output stream
-	 * @throws IOException io write error
 	 */
-	@Throws(IOException::class) //TODO: Drop Java
 	fun copy(inputStream: InputStream, out: OutputStream)
 	{
 		val buffer = ByteArray(BUFFER_SIZE)
@@ -37,9 +35,7 @@ object IOUtils
 	 *
 	 * @param `inputStream` input stream
 	 * @return read failed return ""
-	 * @throws IOException io write error
 	 */
-	@Throws(IOException::class)
 	fun readString(inputStream: InputStream): String
 	{
 		val builder = StringBuilder()
-Original file line number
+Diff line change
@@ Expand Up / @@ -23,7 +23,6 @@ class ShadowsocksTileService : TileService() @@
     		{
     		}
-    		@Throws(RemoteException::class)
     		override fun stateChanged(state: Int, profileName: String?, msg: String?)
     		{
     			val tile = qsTile
@@ Expand Down @@