Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Error Page and Fix #45 #68

Closed
wants to merge 2 commits into from

Conversation

ankit2001
Copy link
Contributor

This PR aims to add an error page in the App and fix #45.

Please review it @fredfalcon, @souravbadami.
Thanks.

@fredfalcon
Copy link
Contributor

The page looks good, but we don't need all of the extra connectivity plugins can you please remove those?
image

Copy link
Contributor

@fredfalcon fredfalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove connectivity plugins and just have a simple error page

@ankit2001
Copy link
Contributor Author

@fredfalcon , where we will use this error page then. Can you please tell me its usecase?

@fredfalcon
Copy link
Contributor

I was originally thinking it would be when there was an error in the app but we can have a toast for that. Maybe this can be the page that happens after a bug is submitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Error Page
2 participants