[processing] Show some more warnings when spatial indexes are missing…

… but desirable
Odzinic · Jul 30, 2020 · fd19167 · fd19167
1 parent 8cbafe7
commit fd19167
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/python/plugins/processing/algs/qgis/SpatialJoinSummary.py b/python/plugins/processing/algs/qgis/SpatialJoinSummary.py
@@ -35,6 +35,7 @@
                        QgsFeatureSink,
                        QgsFeatureRequest,
                        QgsGeometry,
+                       QgsFeatureSource,
                        QgsCoordinateTransform,
                        QgsStatisticalSummary,
                        QgsDateTimeStatisticalSummary,
@@ -160,6 +161,9 @@ def processAlgorithm(self, parameters, context, feedback):
         if join_source is None:
             raise QgsProcessingException(self.invalidSourceError(parameters, self.JOIN))
 
+        if join_source.hasSpatialIndex() == QgsFeatureSource.SpatialIndexNotPresent:
+            feedback.reportError(self.tr("No spatial index exists for join layer, performance will be severely degraded"))
+
         join_fields = self.parameterAsFields(parameters, self.JOIN_FIELDS, context)
         discard_nomatch = self.parameterAsBoolean(parameters, self.DISCARD_NONMATCHING, context)
         summaries = [self.statistics[i][0] for i in

diff --git a/src/analysis/processing/qgsalgorithmclip.cpp b/src/analysis/processing/qgsalgorithmclip.cpp
@@ -96,6 +96,9 @@ QVariantMap QgsClipAlgorithm::processAlgorithm( const QVariantMap &parameters, Q
   if ( !maskSource )
     throw QgsProcessingException( invalidSourceError( parameters, QStringLiteral( "OVERLAY" ) ) );
 
+  if ( featureSource->hasSpatialIndex() == QgsFeatureSource::SpatialIndexNotPresent )
+    feedback->reportError( QObject::tr( "No spatial index exists for input layer, performance will be severely degraded" ) );
+
   QString dest;
   QgsWkbTypes::GeometryType sinkType = QgsWkbTypes::geometryType( featureSource->wkbType() );
   std::unique_ptr< QgsFeatureSink > sink( parameterAsSink( parameters, QStringLiteral( "OUTPUT" ), context, dest, featureSource->fields(), QgsWkbTypes::multiType( featureSource->wkbType() ), featureSource->sourceCrs() ) );

diff --git a/src/analysis/processing/qgsalgorithmextractbyextent.cpp b/src/analysis/processing/qgsalgorithmextractbyextent.cpp
@@ -70,6 +70,9 @@ QVariantMap QgsExtractByExtentAlgorithm::processAlgorithm( const QVariantMap &pa
   if ( !featureSource )
     throw QgsProcessingException( invalidSourceError( parameters, QStringLiteral( "INPUT" ) ) );
 
+  if ( featureSource->hasSpatialIndex() == QgsFeatureSource::SpatialIndexNotPresent )
+    feedback->reportError( QObject::tr( "No spatial index exists for input layer, performance will be severely degraded" ) );
+
   QgsRectangle extent = parameterAsExtent( parameters, QStringLiteral( "EXTENT" ), context, featureSource->sourceCrs() );
   bool clip = parameterAsBoolean( parameters, QStringLiteral( "CLIP" ), context );