Skip to content

Commit

Permalink
Adding more checkboxes, 2 possible formats to display them all
Browse files Browse the repository at this point in the history
  • Loading branch information
Beamanator committed Feb 16, 2022
1 parent a7375a5 commit a000022
Showing 1 changed file with 48 additions and 7 deletions.
55 changes: 48 additions & 7 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,17 +31,58 @@ For example:

- [ ] Verify that no errors appear in the JS console

### PR Review Checklist
### PR Review Checklist (OPTION 1 - checklist for author & C+ - table style)
<!--
This is a checklist for Expensify employees and C+ reviewers. If you are not an Expensify employee or on the C+ team, please leave this section blank. It will be used by the PR reviewer.
This is a checklist for PR authors & reviewers. Please make sure to complete all tasks and mark all with ✅ or else Expensify has the right not to merge your PR!
-->
| Task | PR Author Checklist | C+ Checklist |
|---|:---:|:---:|
| I made sure `main` was pulled before submitting the PR | ❌ / ✅ | ❌ / ✅ |
| I made sure the correct issue is linked in the `### Fixed Issues` section above | ❌ / ✅ | ❌ / ✅ |
| I made sure testing steps are clear and they cover the changes made in this PR | ❌ / ✅ | ❌ / ✅ |
| &nbsp; &nbsp; - I made sure the environment tests should be run in is clearly indicated (Staging vs Production) | ❌ / ✅ | ❌ / ✅ |
| I made sure testing steps cover success & fail scenarios | ❌ / ✅ | ❌ / ✅ |
| I ran the tests & they passed on **all platforms** | ❌ / ✅ | ❌ / ✅ |
| I made sure screenshots or videos were included for [all platforms](https://github.com/Expensify/App/blob/main/CONTRIBUTING.md#make-sure-you-can-test-on-all-platforms) | ❌ / ✅ | ❌ / ✅ |
| I verified there are no console errors related to changes in this PR | ❌ / ✅ | ❌ / ✅ |
| I made sure proper code patterns were followed (see [Reviewing the code](../PR_REVIEW_GUIDELINES.md#reviewing-the-code)) | ❌ / ✅ | ❌ / ✅ |
| &nbsp; &nbsp; - I made sure comments were added when appropriate | ❌ / ✅ | ❌ / ✅ |
| &nbsp; &nbsp; - I made sure any copy / text shown in the product was added in all `src/languages/*` files (if applicable) | ❌ / ✅ | ❌ / ✅ |
| &nbsp; &nbsp; - I made sure proper naming convention was followed for platform-specific files (if applicable) | ❌ / ✅ | ❌ / ✅ |
| &nbsp; &nbsp; - I made sure [style guidelines](../STYLING.md) were followed | ❌ / ✅ | ❌ / ✅ |
| I verified that this PR follows the guidelines as stated in the [Review Guidelines](../PR_REVIEW_GUIDELINES.md) | ❌ / ✅ | ❌ / ✅ |

### PR Review Checklist (OPTION 2 - 2 lists, 1 for author 1 for C+)
#### Contributor (PR Author) Checklist
- [ ] I made sure to pull `main` before submitting my PR for review
- [ ] I linked the correct issue in the `### Fixed Issues` section above
- [ ] I wrote clear testing steps that cover the changes made in this PR
- [ ] I clearly indicated the environment tests should be run in (Staging vs Production)
- [ ] I wrote testing steps that cover success & fail scenarios (if applicable)
- [ ] I ran the tests & they passed on **all platforms**
- [ ] I included screenshots or videos for tests on [all platforms](https://github.com/Expensify/App/blob/main/CONTRIBUTING.md#make-sure-you-can-test-on-all-platforms)
- [ ] I verified there are no console errors related to changes in this PR
- [ ] I followed proper code patterns (see [Reviewing the code](../PR_REVIEW_GUIDELINES.md#reviewing-the-code))
- [ ] I added comments when appropriate
- [ ] I put all copy / text shown in the product in all `src/languages/*` files (if applicable)
- [ ] I followed proper naming convention for platform-specific files (if applicable)
- [ ] I followed style guidelines (in [`Styling.md`](../STYLING.md)) for all style edits I made
- [ ] I followed the guidelines as stated in the [Review Guidelines](../PR_REVIEW_GUIDELINES.md)

#### PR Reviewer Checklist
- [ ] I verified the Author pulled `main` before submitting the PR
- [ ] I verified the correct issue is linked in the `### Fixed Issues` section above
- [ ] I verified testing steps are clear and they cover the changes made in this PR
- [ ] I verified the testing environment is mentioned in the test steps
- [ ] I verified testing steps cover success & fail scenarios (if applicable)
- [ ] I verified tests pass on **all platforms** & I tested again on all platforms
- [ ] I checked that screenshots or videos are included for tests on [all platforms](https://github.com/Expensify/App/blob/main/CONTRIBUTING.md#make-sure-you-can-test-on-all-platforms)
- [ ] I made sure tests pass on **all platforms**
- [ ] I made sure the correct issue is linked in the `### Fixed Issues` section above
- [ ] I made sure testing steps are clear and they cover the changes made in this PR
- [ ] I made sure testing steps cover success & fail scenarios (if applicable)
- [ ] I verified there are no console errors related to changes in this PR
- [ ] I made sure code patterns are acceptable (see [Reviewing the code](../PR_REVIEW_GUIDELINES.md#reviewing-the-code))
- [ ] I verified proper code patterns were followed (see [Reviewing the code](../PR_REVIEW_GUIDELINES.md#reviewing-the-code))
- [ ] I verified comments were added when appropriate
- [ ] I verified any copy / text shown in the product was added in all `src/languages/*` files (if applicable)
- [ ] I verified proper naming convention for platform-specific files was followed (if applicable)
- [ ] I verified [style guidelines](../STYLING.md) were followed
- [ ] I verified that this PR follows the guidelines as stated in the [Review Guidelines](../PR_REVIEW_GUIDELINES.md)

### QA Steps
Expand Down

0 comments on commit a000022

Please sign in to comment.