Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] improve GGPK reading performance #22

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

vlad-zhukov
Copy link

2 changes:

  1. Add an optional callback function to GGPK reader that can be used for subscribing to the reading process instead of wrapping (mutating) internal functions.
  2. Add a timer to only emit progress bar changes once every 200ms. This is a huge performance impovement.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 38.623% when pulling 2c83ff0 on Vlad-Zhukov:dev into 0cde263 on OmegaK2:dev.

@OmegaK2
Copy link
Owner

OmegaK2 commented Feb 23, 2017

I feel like adding the callback function would actually make the original function slower (matters for the API reads), not that I mind limiting the speed at which the reader updates.
If you can update with just the UI code I'll merge the changes, but otherwise I won't.

Wires77 pushed a commit to Wires77/PyPoE that referenced this pull request Mar 3, 2022
Fix to ComponentArmour.dat issue & Remaining Crashes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants