Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added locale option to export data from language subdirs #40

Closed
wants to merge 1 commit into from

Conversation

eps1lon
Copy link
Contributor

@eps1lon eps1lon commented Oct 10, 2017

Adds support to export *.dat files in Data from subdirectories which represent different languages.

Currently language symbols are dumped as unicode symbols. Adding enfore_asci=False to json.dump would convert those to utf8 symbols but I'm not sure if this would break backwards compatibility.

I'm not sure if other distributors contain other languages and if those should be included. Currently the default is not english but rather the base directory. In other distribution this might be e.g. Chinese.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 40.63% when pulling e57c719 on eps1lon:add-locale-option into 3a6a962 on OmegaK2:dev.

@OmegaK2
Copy link
Owner

OmegaK2 commented Oct 10, 2017

I like the idea in general, but I don't think it's necessary to request the locale id which then isn't used. Could just use the full name instead. I just don't have a means to check if that approach works on the Chinese client though

@OmegaK2 OmegaK2 closed this in 4455287 Oct 10, 2017
@eps1lon
Copy link
Contributor Author

eps1lon commented Oct 10, 2017

From a dev standpoint I agree with you. I just thought that using only a locale code was better from a usability standpoint (typing pt is simpler than Portuguese but since this is basically a dev only tool I'm fine with providing the actual subdirectory. Your implementation also doesn't need to be maintained if more languages get added (which should be the case once 3.0.2 hits) which is always nice.

Thanks for implementing this and improving this!

@Chuanhsing
Copy link
Contributor

'cn' => 'Simplified Chinese',
'tw' => 'Traditional Chinese',
and there should also have Spanish, French and German

@eps1lon eps1lon deleted the add-locale-option branch January 2, 2019 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants