Allow simpler extension of CiDetector [BC break] #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanmai
reviewed
Jan 18, 2021
| @@ -30,7 +30,7 @@ class CiDetector | |||
| /** @var Env */ | |||
| private $environment; | |||
|
|
|||
| public function __construct() | |||
| final public function __construct() | |||
There was a problem hiding this comment.
I don't think its necessary to limit usage of the class here. I'm ok with having the class open for extension if someone needs to (and the interface is not enough for whatever reason). As far as they are not able to break the constructor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #64 . This is BC break, because we change CiDetector to have final constructor.
Introduce new
CiDetectorInterface, so that it can be easily extended by eg. decorator, like they do in Infection.