WiP: call failureBlock during setExternalUserId if one or more channels return success of false
#1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cessful - we were always calling the `successBlock` after making the request to set external user ID - now we check if the result has any channels that returned "success" of false and call the `failureBlock`
nan-li
force-pushed
the
fix/setExternalUserId-with-wrong-success-callback
branch
from
1966d25 to
d6c2747
Compare
emawby
reviewed
Oct 4, 2021
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @emawby and @nan-li)
iOS_SDK/OneSignalSDK/Source/OSStateSynchronizer.m, line 205 at r1 (raw file):
[OneSignalClient.sharedClient executeSimultaneousRequests:requests withCompletion:^(NSDictionary<NSString *,NSDictionary *> *results) { var requestDidFail = false;
I would like us to start typing variables in objective-c and avoiding using var!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
successBlockafter making the request to set external user IDsuccessBlockeven when the backend doesn't set it and return the error of invalid auth hathfailureBlockThis change is