Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SpringBootUtilityThinTest fix #2 #30522

Open
wants to merge 1 commit into
base: integration
Choose a base branch
from
Open

SpringBootUtilityThinTest fix #2 #30522

wants to merge 1 commit into from

Conversation

SmithaSubbarao
Copy link
Contributor

@SmithaSubbarao SmithaSubbarao marked this pull request as ready for review January 9, 2025 20:35
@SmithaSubbarao
Copy link
Contributor Author

SmithaSubbarao commented Jan 9, 2025 •
edited by LibbyBot
Loading

!build
(view Open Liberty Personal Build - ✅ completed successfully!)
spawn.zos=true
spawn.fullfat.buckets=com.ibm.ws.springboot.fat20_fat,io.openliberty.springboot.fat30_fat

Note: Target locations of links might be accessible only to IBM employees.

@SmithaSubbarao SmithaSubbarao changed the title SpringBootUtilityThinTest fix #2 DNM: SpringBootUtilityThinTest fix #2 Jan 9, 2025
@LibbyBot
Copy link

LibbyBot commented Jan 9, 2025

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 2 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • Please describe in a separate comment how you tested your changes.

@SmithaSubbarao SmithaSubbarao force-pushed the utlity-thin-test-app-debug branch 2 times, most recently from 674a461 to 360a9e3 Compare January 29, 2025 20:33
@SmithaSubbarao SmithaSubbarao changed the title DNM: SpringBootUtilityThinTest fix #2 SpringBootUtilityThinTest fix #2 Jan 29, 2025
@SmithaSubbarao
Copy link
Contributor Author

SmithaSubbarao commented Jan 29, 2025 •
edited by LibbyBot
Loading

!build
(view Open Liberty Personal Build - ✅ completed successfully!)
spawn.zos=true
spawn.fullfat.buckets=com.ibm.ws.springboot.fat20_fat,io.openliberty.springboot.fat30_fat

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 2 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • Please describe in a separate comment how you tested your changes.

tjwatson
tjwatson requested changes Jan 30, 2025
View reviewed changes
...t.fat20_fat/fat/src/com/ibm/ws/springboot/support/fat/utility/SpringBootUtilityThinTest.java Outdated
Comment on lines 378 to 379
System.out.println(jarEntry.getName());
System.out.printf("JAR File from Uber JAR:", jarEntry.getName());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System.out.println does not help here because any output gets lost. These two prints to System.out should be removed.

@SmithaSubbarao SmithaSubbarao force-pushed the utlity-thin-test-app-debug branch from 360a9e3 to 065c4e8 Compare January 30, 2025 18:35
@SmithaSubbarao
Copy link
Contributor Author

SmithaSubbarao commented Jan 31, 2025 •
edited by LibbyBot
Loading

!build
(view Open Liberty Personal Build - ✅ completed successfully!)
spawn.zos=true
spawn.fullfat.buckets=com.ibm.ws.springboot.fat20_fat,io.openliberty.springboot.fat30_fat

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 2 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • Please describe in a separate comment how you tested your changes.

@SmithaSubbarao SmithaSubbarao force-pushed the utlity-thin-test-app-debug branch from 065c4e8 to 7ecfc20 Compare February 3, 2025 20:00
tjwatson
tjwatson previously approved these changes Feb 3, 2025
View reviewed changes
@SmithaSubbarao
Copy link
Contributor Author

SmithaSubbarao commented Feb 3, 2025 •
edited by LibbyBot
Loading

!build
(view Open Liberty Personal Build - ✅ completed successfully!)
spawn.zos=true
spawn.fullfat.buckets=com.ibm.ws.springboot.fat20_fat,io.openliberty.springboot.fat30_fat

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Feb 3, 2025

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 2 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • Please describe in a separate comment how you tested your changes.

@SmithaSubbarao SmithaSubbarao force-pushed the utlity-thin-test-app-debug branch from 7ecfc20 to 5c0d68b Compare February 20, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjwatson tjwatson tjwatson left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed noproductcode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SmithaSubbarao @LibbyBot @tjwatson