Make combine work with Ref

OpenMDAO · Mar 28, 2024 · b7a81df · b7a81df
1 parent 1596527
commit b7a81df
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/proportional_bands.jl b/src/proportional_bands.jl
@@ -823,9 +823,9 @@ end
 """
     combine(pbs::AbstractArray{<:AbstractProportionalBandSpectrum,N}, outcbands::AbstractProportionalBands{NO,:center}) where {N}
 
-Combine each input proportional band spectrum of `pbs` into one output proportional band spectrum using the proportional bands indicated by `outcbands`.
+Combine each input proportional band spectrum of `pbs` into one output proportional band spectrum using the proportional center bands indicated by `outcbands`.
 """
-function combine(pbs::AbstractArray{<:AbstractProportionalBandSpectrum,N}, outcbands::AbstractProportionalBands{NO,:center}) where {N,NO}
+function combine(pbs::Union{AbstractArray{<:AbstractProportionalBandSpectrum,N},Base.RefValue{<:AbstractProportionalBandSpectrum}}, outcbands::AbstractProportionalBands{NO,:center}) where {N,NO}
    # Create the vector that will contain the new PBS.
    # An <:AbstractProportionalBandSpectrum is <:AbstractVector{TF}, so AbstractArray{<:AbstractProportionalBandSpectrum,N} is actually an Array of AbstractVectors.
    # So `eltype(eltype(pbs))` should give me the element type of the PBS.

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -2178,6 +2178,10 @@ end
                 end
                 i = length(pbs_combined)
                 @test pbs_combined[i] ≈ pbs1[i]/(ubands1[i] - lbands1[i])*(ubands1[i] - outlbands[i])
+
+                # Can I do the `combine` thing with a `Ref`?
+                pbs_combined2 = combine(Ref(pbs1), outcbands)
+                @test all(pbs_combined2 .≈ pbs_combined)
             end
         end