-
-
Notifications
You must be signed in to change notification settings - Fork 53
Updated file extension checking #528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated file extension checking #528
Conversation
Updated the file extension checking to support both lowercase and uppercase (or mixed, like .MiDi)
opening files via executable argument (like Windows' "open with") will need to be adjusted |
Fixed checks to support uppercase file extensions via cli
I have a question: auto-saving isn't exactly making a backup (for automatic recovery), right? I changed the way the function is called on autosave (removing the "true" in the last argument) to be able to show the message that the song was saved, since I think that visually showing that the song was saved (like showing the message or just removing the "*" from the window title) is better. |
It's not advised to do that since saving without the backup set to true will cause selections to be deselected |
`tonextsave` has been moved to be defined after the load_settings call, preventing auto-saving when opening the first song after loading the game. And if autosave is enabled, it'll receive the value of autosavemins. Else, it'll be 0.
Added the var asave; It's an optional argument. If asave is true, selection_replace won't be called and the message will be "Song auto saved" ("歌曲自动保存" if laanguage is chinese)
The real operations said in previous commits
Updated file extension checking for ".nbp", ".ogg" and ".wav" to be case-insensitive. And a syntax fix for the latest GMS versions.
Now case-insensitive
Now case-insensitive
Added multiple __MACOSX-related paths to .gitignore to prevent accidental commits of macOS-specific shaders.
Theoretically the last file extension check
I believe the fix is now complete! |
Updated file extension checking to support uppercase and lowercase letters (or a combination of them, such as .MiDi).
These fixes are related to issue #396.