Welcome to QueryBuilderProvider! #29
Conversation
| // Don't do anything, this is not a searchable field | ||
| return $this->query; | ||
| } elseif ($searchType == DefaultSearchable::NORMAL()) { | ||
| $this->query->orWhere($column->getName(), 'LIKE', '%' . $searchValue . '%'); |
There was a problem hiding this comment.
I remember having problems with postgresql users that wanted to use iLIKE in their queries.
Should we consider that or providing the option to override any column query?
There was a problem hiding this comment.
We already really have the option to override any column query with the Searchable types, so we just need to add one for case insensitive as another option.
The only thing is that then that the QueryBuilderProvider would need to know what database it is running on so that we can build the correct query depending on wether the database is MySQL or Postgres.
Maybe adding ->isPostgres and ->isMySQL as functions on this class might not be a bad idea? Then at least we can throw errors if we can't build the correct query for a db...
Either way, I am not really worried about this until someone opens a bug or feature request :)
|
Seems fair enough to wait for anyone complaining :) |
Welcome to QueryBuilderProvider!
I have a present for all of you <3
This implements Feature Request #19 and #5