Change sha1 to sha256 in server/client cert generation #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed sha1 to sha256 in server/client cert generation
Johnlabo3
approved these changes
Jan 13, 2022
tungmeoo
approved these changes
Jan 14, 2023
|
good |
Amin649136411
approved these changes
Apr 2, 2023
| @@ -356,7 +356,7 @@ if [ -d "$KEY_DIR" ] && [ "$KEY_CONFIG" ]; then | |||
| ( [ $DO_REQ -eq 0 ] || $OPENSSL req $BATCH -days $KEY_EXPIRE $NODES_REQ -new -newkey rsa:$KEY_SIZE \ | |||
| -keyout "$FN.key" -out "$FN.csr" $REQ_EXT -config "$KEY_CONFIG" $PKCS11_ARGS ) && \ | |||
| ( [ $DO_CA -eq 0 ] || $OPENSSL ca $BATCH -days $KEY_EXPIRE -out "$FN.crt" \ | |||
| -in "$FN.csr" $CA_EXT -md sha1 -config "$KEY_CONFIG" ) && \ | |||
| -in "$FN.csr" $CA_EXT -md sha256 -config "$KEY_CONFIG" ) && \ | |||
There was a problem hiding this comment.
Suggested change
| -in "$FN.csr" $CA_EXT -md sha256 -config "$KEY_CONFIG" ) && \ | |
| -in "$FN.csr" $CA_EXT -md sha256 -config "$KEY_CONFIG" ) && \ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a problem where OpenVPN on Android couldn't connect because it deemed my certs "too weak". After searching on the topic, I found that you need to change default_md in openssl.conf to sha256, but unfortunately, that didn't help. I then realised that my client/server certs were sha1 despite the change in the config, and I thought "why not find it in the pkitool and change it", and voila, it worked perfectly!