Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(LoadUnit): use lqIdx to determine age #4136

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

Anzooooo
Copy link
Member

@Anzooooo Anzooooo commented Jan 6, 2025

  1. lqIdx has less bit width.
  2. for vectors, the robIdx is the same for multiple flows. Previously, for vectors, we would additionally use uopIdx for judgement. But actually, in theory, we only need to use lqIdx/sqIdx.

Here we change the age judgement for vectors to lqIdx to ensure accurate age judgement. And change the age judgement of scalar to lqIdx as well to reduce the cost.

1. `lqIdx` has less bit width.
2. for vectors, the `robIdx` is the same for multiple `flow`s. Previously, for vectors, we would additionally use `uopIdx` for judgement. But actually, in theory, we only need to use `lqIdx/sqIdx`.

Here we change the age judgement for vectors to `lqIdx` to ensure accurate age judgement. And change the age judgement of scalar to `lqIdx` as well to reduce the cost.
@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: e654aa3

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
e654aa3 1.814 0.442 2.639 1.231 2.152 2.141 2.361 0.933 1.406 1.985 3.107 2.558 2.267 3.308

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
4d393af 1.231 2.152 2.141 0.933 1.985 3.107 3.308
7cc7723 0.442 2.639 2.361 1.407 2.558
398aeef 1.814 0.442 2.639 1.231 2.152 2.141 2.361 0.933 1.403 1.985 3.107 2.558 2.267 3.308
d94fbff 1.814 0.442 2.639 1.231 2.152 2.141 2.361 0.933 1.403 1.985 3.107 2.558 2.267 3.308
3642c22 1.814 0.442 2.639 1.231 2.152 2.141 2.361 0.933 1.403 1.985 3.107 2.558 2.267 3.308

@Anzooooo Anzooooo marked this pull request as ready for review January 6, 2025 14:40
@Tang-Haojin Tang-Haojin merged commit c75efc0 into master Jan 7, 2025
9 checks passed
@Tang-Haojin Tang-Haojin deleted the wzz-fix-lqidx branch January 7, 2025 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants