Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(StoreQueue): remove the incorrect redirect logic #4139

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

Anzooooo
Copy link
Member

@Anzooooo Anzooooo commented Jan 6, 2025

The line of code that was removed was written by me, but I can't now think of any reason at all why I would have added this incorrect line of code at the time.

The line of code doesn't seem to make any sense and only generates errors. 😭

The line of code that was removed was written by me, but I can't now think of any reason at all why I would have added this incorrect line of code at the time.
The line of code doesn't seem to make any sense and only generates errors.
@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: 6b984e2

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
6b984e2 1.814 0.442 2.639 1.231 2.152 2.141 2.361 0.933 1.406 1.985 3.107 2.558 2.267 3.308

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
4d393af 1.814 1.231 2.152 2.141 0.933 1.985 3.107 2.267 3.308
7cc7723 0.442 2.639 1.231 2.361 0.933 1.407 1.985 3.107 2.558 3.308
398aeef 1.814 0.442 2.639 1.231 2.152 2.141 2.361 0.933 1.403 1.985 3.107 2.558 2.267 3.308
d94fbff 1.814 0.442 2.639 1.231 2.152 2.141 2.361 0.933 1.403 1.985 3.107 2.558 2.267 3.308
3642c22 1.814 0.442 2.639 1.231 2.152 2.141 2.361 0.933 1.403 1.985 3.107 2.558 2.267 3.308

@Anzooooo Anzooooo marked this pull request as ready for review January 7, 2025 03:28
@linjuanZ linjuanZ merged commit 14651e9 into master Jan 7, 2025
9 checks passed
@linjuanZ linjuanZ deleted the wzz-fix-sq-excp branch January 7, 2025 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants