Skip to content

Commit

Permalink
Fixed parsing 2.5.3 MovementInfo and add MovementFlag3
Browse files Browse the repository at this point in the history
  • Loading branch information
Shauren committed Feb 23, 2022
1 parent b7749f8 commit 14e3537
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 3 deletions.
11 changes: 11 additions & 0 deletions WowPacketParser/Enums/MovementFlag3.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
using System;

namespace WowPacketParser.Enums
{
[Flags]
public enum MovementFlag3 : uint
{
None = 0x00000000,
DisableInertia = 0x00000001,
}
}
13 changes: 10 additions & 3 deletions WowPacketParserModule.V2_5_1_38707/Parsers/UpdateHandler.cs
Original file line number Diff line number Diff line change
Expand Up @@ -141,9 +141,8 @@ private static MovementInfo ReadMovementUpdateBlock(Packet packet, WowGuid guid,
if (ClientVersion.AddedInVersion(ClientVersionBuild.V2_5_3_41812))
{
moveInfo.Flags = (uint)packet.ReadUInt32E<MovementFlag>("Movement Flags", index);
moveInfo.Flags2 = (uint)packet.ReadUInt32E<MovementFlag2>("Extra Movement Flags", index);

packet.ReadUInt32("MovementFlags3", index);
moveInfo.Flags2 = (uint)packet.ReadUInt32E<MovementFlag2>("Movement Flags 2", index);
moveInfo.Flags3 = (uint)packet.ReadUInt32E<MovementFlag3>("Movement Flags 3", index);
}

packet.ReadUInt32("MoveTime", index);
Expand All @@ -170,10 +169,18 @@ private static MovementInfo ReadMovementUpdateBlock(Packet packet, WowGuid guid,
packet.ReadBit("HasSpline", index);
packet.ReadBit("HeightChangeFailed", index);
packet.ReadBit("RemoteTimeValid", index);
var hasInertia = ClientVersion.AddedInVersion(ClientVersionBuild.V2_5_3_41812) && packet.ReadBit("Has Inertia", index);

if (hasTransport)
V8_0_1_27101.Parsers.UpdateHandler.ReadTransportData(moveInfo, guid, packet, index);

if (hasInertia)
{
packet.ReadPackedGuid128("GUID", index, "Inertia");
packet.ReadVector3("Force", index, "Inertia");
packet.ReadUInt32("Lifetime", index, "Inertia");
}

if (hasFall)
{
packet.ResetBitReader();
Expand Down

0 comments on commit 14e3537

Please sign in to comment.