Make NuGet install fire and forget

fixes ErikEJ#1703
OttarYrjan · Feb 24, 2023 · 1d105d5 · 1d105d5
1 parent 711dc64
commit 1d105d5
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 28 deletions.
diff --git a/src/GUI/Shared/Handlers/ReverseEngineer/ReverseEngineerHandler.cs b/src/GUI/Shared/Handlers/ReverseEngineer/ReverseEngineerHandler.cs
@@ -313,12 +313,7 @@ private static async Task InstallNuGetPackagesAsync(Project project, bool onlyGe
 
                 foreach (var nuGetPackage in packages)
                 {
-                    var done = nuGetHelper.InstallPackage(nuGetPackage.PackageId, project, new Version(nuGetPackage.Version));
-
-                    if (!done)
-                    {
-                        await VS.StatusBar.ShowMessageAsync("Provider package installation failed, install manually.");
-                    }
+                    nuGetHelper.InstallPackage(nuGetPackage.PackageId, project, new Version(nuGetPackage.Version));
                 }
             }
 

diff --git a/src/GUI/Shared/Helpers/NuGetHelper.cs b/src/GUI/Shared/Helpers/NuGetHelper.cs
@@ -6,7 +6,7 @@ namespace EFCorePowerTools.Helpers
 {
     public class NuGetHelper
     {
-        public bool InstallPackage(string packageId, Project project, Version version = null)
+        public void InstallPackage(string packageId, Project project, Version version = null)
         {
             var args = $"add \"{project.FullPath}\" package {packageId} ";
             if (version != null)
@@ -20,34 +20,17 @@ public bool InstallPackage(string packageId, Project project, Version version =
                 Arguments = args,
             };
 
-            var result = RunProcess(startInfo);
-
-            return result;
+            RunProcess(startInfo);
         }
 
-        private static bool RunProcess(ProcessStartInfo startInfo)
+        private static void RunProcess(ProcessStartInfo startInfo)
         {
             startInfo.UseShellExecute = false;
             startInfo.RedirectStandardOutput = true;
             startInfo.RedirectStandardError = true;
             startInfo.CreateNoWindow = true;
 
-            var completed = true;
-
-            using (var process = Process.Start(startInfo))
-            {
-                while (process != null && !process.HasExited)
-                {
-                    completed = false;
-                }
-
-                if (process != null && process.HasExited)
-                {
-                    completed = process.ExitCode == 0;
-                }
-            }
-
-            return completed;
+            Process.Start(startInfo);
         }
     }
 }
diff --git a/test/Ef7Playground/Ef7Playground/Models/NorthwindContext.Functions.cs b/test/Ef7Playground/Ef7Playground/Models/NorthwindContext.Functions.cs
@@ -11,7 +11,7 @@ public partial class NorthwindContext
     {
 
         [DbFunction("ISOweek", "dbo")]
-        public static int? _ISOweek(DateTime? DATE)
+        public static int? ISOweek(DateTime? DATE)
         {
             throw new NotSupportedException("This method can only be called from Entity Framework Core queries");
         }