Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow to publish docker & helms [master] #692

Merged
merged 5 commits into from
Mar 31, 2021

Conversation

vainyksi
Copy link
Contributor

@vainyksi vainyksi commented Mar 30, 2021

Update workflow to publish docker & helm charts

  • workflow should expect & use already released & published lighty-core artifacts in maven-central. These release artifacts is used & included during building docker image.
  • also the workflow is updated with another parameter to specify if the image to publish is also latest docker image, so latest tag will be applied for the image and pushed to docker hub.
  • merged multiple version parameters into single value, minimizing cases when the user forget to input helm-charts version. The version used for docker tag and helm charts is same for most use-cases, if not for every use-case.

Michal Banik added 3 commits March 30, 2021 16:36
Force to expect that all needed artefacts are already build and published to maven central

Signed-off-by: Michal Banik <[email protected]>
Signed-off-by: Michal Banik <[email protected]>
@vainyksi vainyksi requested review from marekzatko and Pyro2266 March 30, 2021 14:45
@vainyksi vainyksi changed the title Update workflow to publish docker & helms Update workflow to publish docker & helms [master] Mar 30, 2021
@marekzatko
Copy link
Contributor

Maybe we want to change the description of helm chart of lighty-rnc from the default one https://github.com/PANTHEONtech/helm-charts/blob/main/index.yaml#L7 ?
That can be changed in Chart.yaml.
Otherwise the workflow looks fine, but one question:
If you now pushed for example version 14.0.0 without latest tag, would the latest tag stay on the current version (13.2.1) ?

@vainyksi
Copy link
Contributor Author

vainyksi commented Mar 31, 2021

Maybe we want to change the description of helm chart of lighty-rnc from the default one https://github.com/PANTHEONtech/helm-charts/blob/main/index.yaml#L7 ?
That can be changed in Chart.yaml.

👍

If you now pushed for example version 14.0.0 without latest tag, would the latest tag stay on the current version (13.2.1) ?

correct

@vainyksi vainyksi merged commit 3384bb3 into PANTHEONtech:master Mar 31, 2021
@vainyksi vainyksi deleted the rnc-docker-master branch March 31, 2021 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants