Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make modules information in publish workflow configurable - master #813

Merged
merged 12 commits into from
Sep 10, 2021
Merged

Make modules information in publish workflow configurable - master #813

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
47d17ce
Fix module name inside publish-docker-helm workflow
PeterSuna Sep 2, 2021
f9c2942
Revert "Fix module name inside publish-docker-helm workflow"
PeterSuna Sep 9, 2021
100b202
Rename lighty-rcgnmi-app-module -> lighty-rcgnmi-module
PeterSuna Sep 9, 2021
3768912
Add naming convention to lighty-applications README
PeterSuna Sep 9, 2021
2cd6445
Revert "Add naming convention to lighty-applications README"
PeterSuna Sep 9, 2021
a732bfb
Revert "Rename lighty-rcgnmi-app-module -> lighty-rcgnmi-module"
PeterSuna Sep 9, 2021
0c58c42
Add configurable modules information in publish workflow
PeterSuna Sep 9, 2021
91638a4
Remove redundant default values and colon
PeterSuna Sep 9, 2021
4f55c22
Fix missed helm values path
PeterSuna Sep 9, 2021
f52c41d
Remove default values and fix description in publish workflow
PeterSuna Sep 10, 2021
7e92dc7
Add examples for deploy workflow inputs descriptions
Sep 10, 2021
7de8706
small update in deploy workflow inputs descriptions
Sep 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "Fix module name inside publish-docker-helm workflow" 
This reverts commit 47d17ce.

Signed-off-by: Peter Suna <[email protected]>
  • Loading branch information
@PeterSuna
PeterSuna committed Sep 9, 2021
commit f9c2942e1ba14b4aff663dbf86e6ecb028864de8
2 changes: 1 addition & 1 deletion .github/workflows/publish-docker-helm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ jobs:
echo "DOCKER_IMAGE_NAME=$(echo $DOCKER_IMAGE_NAME)" >> $GITHUB_ENV
echo "DOCKER_IMAGE_NAME_TAG=$(echo $DOCKER_IMAGE_NAME_TAG)" >> $GITHUB_ENV
- name: Build docker image
run: mvn install -B -pl :${{ github.event.inputs.app-name }}-app-module,:${{ github.event.inputs.app-name }}-app,:${{ github.event.inputs.app-name }}-app-docker -P docker
run: mvn install -B -pl :${{ github.event.inputs.app-name }}-module,:${{ github.event.inputs.app-name }}-app,:${{ github.event.inputs.app-name }}-app-docker -P docker
- name: Tag image
run: |
image_name=$(mvn help:evaluate -f ${{ env.app-aggregator-dir}}/${{ github.event.inputs.app-name }}-app-docker/pom.xml -Dexpression=image.name -q -DforceStdout)
Expand Down