Skip to content

Commit

Permalink
🚮 [Page attachments] amp-story-page-attachment-ui-v2 experiment cle…
Browse files Browse the repository at this point in the history
…anup (ampproject#35421)

* Clean up page-attachment css file.

* Clean up experiment.

* Update tests and template.

* Remove experiment config variables

* Protected variables.

* whitespace

* Cleanup visual tests.

* Theme background

* const and remove variable.

* Whitespace

* Revert config, save for follow up PR

* Revert config, save for follow up PR
  • Loading branch information
processprocess authored Aug 10, 2021
1 parent 18675fd commit 11c16b7
Show file tree
Hide file tree
Showing 18 changed files with 641 additions and 1,223 deletions.
22 changes: 1 addition & 21 deletions examples/amp-story/attachment.html
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@
<amp-story-grid-layer template="vertical">
<p>
<span data-text-background-color="#00A3DB">Default amp-story-page-attachment.</span></br></br>
<span data-text-background-color="#00A3AB">Enable experiment by pasting AMP.toggleExperiment('amp-story-page-attachment-ui-v2', true) in console and refreshing.</span>
</p>
</amp-story-grid-layer>
<amp-story-page-attachment data-title="Lorem ipsum" layout="nodisplay">
Expand All @@ -85,22 +84,14 @@
<amp-story-grid-layer template="vertical">
<p>
<span data-text-background-color="#00A3DB">amp-story-page-attachment: dark theme.</span></br></br>
<span data-text-background-color="#00A3AB">Enable experiment by pasting AMP.toggleExperiment('amp-story-page-attachment-ui-v2', true) in console and refreshing.</span>
</p>
</amp-story-grid-layer>
<amp-story-page-attachment
title="Lorem ipsum"
layout="nodisplay"
theme="dark"
>
<p> Lots of content. Opens to max of 80% then scrolls.</p>

<p>In nisl nisi scelerisque eu ultrices vitae auctor eu. Tristique magna sit amet purus gravida. Tincidunt id aliquet risus feugiat in ante metus dictum. Mattis nunc sed blandit libero volutpat sed. Imperdiet massa tincidunt nunc pulvinar sapien et ligula ullamcorper malesuada. Sit amet mattis vulputate enim nulla aliquet porttitor lacus luctus. Proin sagittis nisl rhoncus mattis rhoncus. Pulvinar neque laoreet suspendisse interdum consectetur libero. Nibh tellus molestie nunc non blandit massa enim nec dui. Sagittis eu volutpat odio facilisis. Tristique senectus et netus et malesuada fames ac. Molestie a iaculis at erat. Sit amet cursus sit amet. Suscipit tellus mauris a diam maecenas sed enim ut. Gravida quis blandit turpis cursus in. Tincidunt vitae semper quis lectus nulla at volutpat diam ut. Morbi tempus iaculis urna id. Faucibus et molestie ac feugiat sed lectus vestibulum. Mauris augue neque gravida in. Ac turpis egestas sed tempus.</p>

<p>In nisl nisi scelerisque eu ultrices vitae auctor eu. Tristique magna sit amet purus gravida. Tincidunt id aliquet risus feugiat in ante metus dictum. Mattis nunc sed blandit libero volutpat sed. Imperdiet massa tincidunt nunc pulvinar sapien et ligula ullamcorper malesuada. Sit amet mattis vulputate enim nulla aliquet porttitor lacus luctus. Proin sagittis nisl rhoncus mattis rhoncus. Pulvinar neque laoreet suspendisse interdum consectetur libero. Nibh tellus molestie nunc non blandit massa enim nec dui. Sagittis eu volutpat odio facilisis. Tristique senectus et netus et malesuada fames ac. Molestie a iaculis at erat. Sit amet cursus sit amet. Suscipit tellus mauris a diam maecenas sed enim ut. Gravida quis blandit turpis cursus in. Tincidunt vitae semper quis lectus nulla at volutpat diam ut. Morbi tempus iaculis urna id. Faucibus et molestie ac feugiat sed lectus vestibulum. Mauris augue neque gravida in. Ac turpis egestas sed tempus.</p>

<p>Ut tristique et egestas quis ipsum. Aliquam malesuada bibendum arcu vitae elementum curabitur vitae nunc sed. Elementum curabitur vitae nunc sed velit dignissim. Tristique et egestas quis ipsum suspendisse ultrices gravida dictum fusce. At elementum eu facilisis sed odio morbi. Imperdiet proin fermentum leo vel orci porta non. Quam lacus suspendisse faucibus interdum. Eu non diam phasellus vestibulum lorem sed risus. Commodo viverra maecenas accumsan lacus vel facilisis volutpat est velit. Sagittis aliquam malesuada bibendum arcu vitae elementum. Ut sem viverra aliquet eget sit amet. Nulla facilisi morbi tempus iaculis. Sed odio morbi quis commodo odio aenean sed adipiscing diam. Donec ultrices tincidunt arcu non sodales. Amet venenatis urna cursus eget. Sapien et ligula ullamcorper malesuada proin. Tristique sollicitudin nibh sit amet commodo nulla facilisi. Venenatis tellus in metus vulputate eu scelerisque felis.</p>
<a href="https://linkinattachment.com">Link in page attachment</a>
<p> A little content. Opens to max of content.</p>
</amp-story-page-attachment>
</amp-story-page>

Expand All @@ -111,7 +102,6 @@
<amp-story-grid-layer template="vertical">
<p>
<span data-text-background-color="#00A3DB">amp-story-page-attachment: one image.</span></br></br>
<span data-text-background-color="#00A3AB">Enable experiment by pasting AMP.toggleExperiment('amp-story-page-attachment-ui-v2', true) in console and refreshing.</span>
</p>
</amp-story-grid-layer>
<amp-story-page-attachment
Expand Down Expand Up @@ -140,7 +130,6 @@
<amp-story-grid-layer template="vertical">
<p>
<span data-text-background-color="#00A3DB">amp-story-page-attachment: two images & dark theme.</span></br></br>
<span data-text-background-color="#00A3AB">Enable experiment by pasting AMP.toggleExperiment('amp-story-page-attachment-ui-v2', true) in console and refreshing.</span>
</p>
</amp-story-grid-layer>
<amp-story-page-attachment
Expand Down Expand Up @@ -169,7 +158,6 @@
<amp-story-grid-layer template="center">
<p>
<span data-text-background-color="crimson">Default amp-story-page-outlink.</span></br></br>
<span data-text-background-color="#00A3AB">Enable experiment by pasting AMP.toggleExperiment('amp-story-page-attachment-ui-v2', true) in console and refreshing.</span>
</p>
</amp-story-grid-layer>
<amp-story-page-outlink
Expand All @@ -185,7 +173,6 @@
<amp-story-grid-layer template="center">
<p>
<span data-text-background-color="crimson">amp-story-page-outlink: logo & custom text.</span></br></br>
<span data-text-background-color="#00A3AB">Enable experiment by pasting AMP.toggleExperiment('amp-story-page-attachment-ui-v2', true) in console and refreshing.</span>
</p>
</amp-story-grid-layer>
<amp-story-page-outlink
Expand All @@ -202,7 +189,6 @@
<amp-story-grid-layer template="center">
<p>
<span data-text-background-color="crimson">amp-story-page-outlink: no image.</span></br></br>
<span data-text-background-color="#00A3AB">Enable experiment by pasting AMP.toggleExperiment('amp-story-page-attachment-ui-v2', true) in console and refreshing.</span>
</p>
</amp-story-grid-layer>
<amp-story-page-outlink
Expand All @@ -219,7 +205,6 @@
<amp-story-grid-layer template="center">
<p>
<span data-text-background-color="crimson">amp-story-page-outlink: dark theme.</span></br></br>
<span data-text-background-color="#00A3AB">Enable experiment by pasting AMP.toggleExperiment('amp-story-page-attachment-ui-v2', true) in console and refreshing.</span>
</p>
</amp-story-grid-layer>
<amp-story-page-outlink
Expand All @@ -236,7 +221,6 @@
<amp-story-grid-layer template="center">
<p>
<span data-text-background-color="crimson">amp-story-page-outlink: custom pink background.</span></br></br>
<span data-text-background-color="#00A3AB">Enable experiment by pasting AMP.toggleExperiment('amp-story-page-attachment-ui-v2', true) in console and refreshing.</span>
</p>
</amp-story-grid-layer>
<amp-story-page-outlink
Expand All @@ -255,7 +239,6 @@
<amp-story-grid-layer template="center">
<p>
<span data-text-background-color="crimson">amp-story-page-outlink: custom pink text.</span></br></br>
<span data-text-background-color="#00A3AB">Enable experiment by pasting AMP.toggleExperiment('amp-story-page-attachment-ui-v2', true) in console and refreshing.</span>
</p>
</amp-story-grid-layer>
<amp-story-page-outlink
Expand All @@ -274,7 +257,6 @@
<amp-story-grid-layer template="center">
<p>
<span data-text-background-color="crimson">amp-story-page-outlink: custom navy background.</span></br></br>
<span data-text-background-color="#00A3AB">Enable experiment by pasting AMP.toggleExperiment('amp-story-page-attachment-ui-v2', true) in console and refreshing.</span>
</p>
</amp-story-grid-layer>
<amp-story-page-outlink
Expand All @@ -293,7 +275,6 @@
<amp-story-grid-layer template="center">
<p>
<span data-text-background-color="crimson">amp-story-page-outlink: custom navy text.</span></br></br>
<span data-text-background-color="#00A3AB">Enable experiment by pasting AMP.toggleExperiment('amp-story-page-attachment-ui-v2', true) in console and refreshing.</span>
</p>
</amp-story-grid-layer>
<amp-story-page-outlink
Expand All @@ -312,7 +293,6 @@
<amp-story-grid-layer template="center">
<p>
<span data-text-background-color="crimson">Legacy outlink (amp-story-page-attachment with an href) using title, data-title, cta-text, and data-cta-text attributes.</span></br></br>
<span data-text-background-color="#00A3AB">Enable experiment by pasting AMP.toggleExperiment('amp-story-page-attachment-ui-v2', true) in console and refreshing.</span>
</p>
</amp-story-grid-layer>
<amp-story-page-attachment
Expand Down

This file was deleted.

198 changes: 0 additions & 198 deletions examples/visual-tests/amp-story/amp-story-page-attachment-v2.html

This file was deleted.

Loading

0 comments on commit 11c16b7

Please sign in to comment.