Skip to content

Commit

Permalink
fix: reduce level of duplicate and noisy logging (#14412)
Browse files Browse the repository at this point in the history
  • Loading branch information
jdpgrailsdev committed Oct 21, 2024
1 parent e1bb6a7 commit 3d4b2c6
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ private ReplicationOutput getReplicationOutput(final String workloadId) {
}
});

log.info("Replication output for workload {} : {}", workloadId, output.orElse(null));
log.debug("Replication output for workload {} : {}", workloadId, output.orElse(null));
return output.orElse(null);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -238,12 +238,12 @@ private StandardSyncOutput finalizeOutput(final ReplicationActivityInput replica
final StandardSyncOutput standardSyncOutput = reduceReplicationOutput(attemptOutput, metricAttributes);

final String standardSyncOutputString = standardSyncOutput.toString();
LOGGER.info("sync summary: {}", standardSyncOutputString);
LOGGER.debug("sync summary: {}", standardSyncOutputString);
if (standardSyncOutputString.length() > MAX_TEMPORAL_MESSAGE_SIZE) {
LOGGER.error("Sync output exceeds the max temporal message size of {}, actual is {}.", MAX_TEMPORAL_MESSAGE_SIZE,
standardSyncOutputString.length());
} else {
LOGGER.info("Sync summary length: {}", standardSyncOutputString.length());
LOGGER.debug("Sync summary length: {}", standardSyncOutputString.length());
}

if (featureFlagClient.boolVariation(WriteOutputCatalogToObjectStorage.INSTANCE, new Connection(tracingContext.connectionId))) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -213,12 +213,12 @@ private StandardSyncOutput finalizeOutput(final ReplicationActivityInput replica
final StandardSyncOutput standardSyncOutput = reduceReplicationOutput(attemptOutput, metricAttributes);

final String standardSyncOutputString = standardSyncOutput.toString();
LOGGER.info("sync summary: {}", standardSyncOutputString);
LOGGER.debug("sync summary: {}", standardSyncOutputString);
if (standardSyncOutputString.length() > MAX_TEMPORAL_MESSAGE_SIZE) {
LOGGER.error("Sync output exceeds the max temporal message size of {}, actual is {}.", MAX_TEMPORAL_MESSAGE_SIZE,
standardSyncOutputString.length());
} else {
LOGGER.info("Sync summary length: {}", standardSyncOutputString.length());
LOGGER.debug("Sync summary length: {}", standardSyncOutputString.length());
}

if (featureFlagClient.boolVariation(WriteOutputCatalogToObjectStorage.INSTANCE, new Connection(tracingContext.connectionId))) {
Expand Down

0 comments on commit 3d4b2c6

Please sign in to comment.