Use Provider to provide signing config information at runtime #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfiguration phase. Fixes PatilShreyas#9
PatilShreyas
approved these changes
Jun 18, 2024
| keySource: KeySource?, | ||
| project: Project, | ||
| variant: T | ||
| ): Provider<Sha256DigestableKey?> where T : Variant = project.provider { |
There was a problem hiding this comment.
This was a nice catch. Thanks for a fix 👍🏻
|
@matejsemancik change looks good, but currently CI is breaking due to formatting issues here as well. Can you please reformat it with spotless? Just run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Provider to evaluate encryption key at task runtime instead of plugin configuration phase.
Fixes #9