Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid compiler warnings on compilers supporting std::uncaught_exceptions() #12

Merged
merged 2 commits into from
Dec 4, 2020

Conversation

PerMalmberg
Copy link
Owner

No description provided.

@PerMalmberg
Copy link
Owner Author

@HpLightcorner When adding this little fix I noticed the test you added (Adding 1000 Tasks to two Cron-Objects expiring after 1 second calling add_schedule) constantly fails. Can you please have a look at it and make a PR?

@HpLightcorner
Copy link
Contributor

@PerMalmberg yes, for sure - let me take a look and come back with a PR

@HpLightcorner
Copy link
Contributor

@PerMalmberg sorry for being so late with my reply - quite busy times....
I had a look at the Issue and I think we should remove this test as it is indeed depending on the CPU performance of the machine executing the test (which at least shown me that I was able to improve performance during development). What is your opinion?

@PerMalmberg
Copy link
Owner Author

@PerMalmberg sorry for being so late with my reply - quite busy times....
I had a look at the Issue and I think we should remove this test as it is indeed depending on the CPU performance of the machine executing the test (which at least shown me that I was able to improve performance during development). What is your opinion?

I'm OK with that.

@PerMalmberg PerMalmberg merged commit 9edb758 into master Dec 4, 2020
@PerMalmberg PerMalmberg deleted the bug/fix-compiler-warnings branch December 4, 2020 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants