IDEA-306278 vcs: warn about invalid CLM state in VcsShelveChangesSaver

GitOrigin-RevId: bd9ebe0b2b3603b1c21893c4fdc8bfe36120eac3

platform/vcs-impl/src/com/intellij/openapi/vcs/changes/VcsShelveChangesSaver.java

@@ -49,6 +49,11 @@ public void save(@NotNull Collection<? extends VirtualFile> rootsToSave) throws
  ChangeListManager changeListManager = ChangeListManager.getInstance(project);
  Collection<Change> allChanges = changeListManager.getAllChanges();
 
+ if (ContainerUtil.exists(allChanges, change -> change.getBeforeRevision() instanceof FakeRevision ||
+ change.getAfterRevision() instanceof FakeRevision)) {
+ LOG.error("Local changes are not up-to-date yet. Changes saving may not be accurate.", new Throwable());
+ }
+
  Set<VirtualFile> rootsSet = new HashSet<>(rootsToSave);
  if (changeListManager.areChangeListsEnabled()) {
  for (LocalChangeList list : changeListManager.getChangeLists()) {
@@ -98,7 +103,8 @@ protected void doRollback(@NotNull Collection<? extends VirtualFile> rootsToSave
  }
 
  @NotNull
- private List<Change> filterChangesByRoots(@NotNull Collection<? extends Change> changes, @NotNull Set<? extends VirtualFile> rootsToSave) {
+ private List<Change> filterChangesByRoots(@NotNull Collection<? extends Change> changes,
+ @NotNull Set<? extends VirtualFile> rootsToSave) {
  ProjectLevelVcsManager vcsManager = ProjectLevelVcsManager.getInstance(project);
  return ContainerUtil.filter(changes, change -> {
  return rootsToSave.contains(vcsManager.getVcsRootFor(ChangesUtil.getFilePath(change)));