Skip to content

Commit

Permalink
[BREAKING CHANGE] Require Node.js >= 10
Browse files Browse the repository at this point in the history
- Several deps started requiring it
- CI started breaking on Node 8
- Node 8 is end-of-life, no longer maintained
- Even latest Debian stable and Ubuntu LTS ship Node 10:
    https://packages.debian.org/search?suite=stable&keywords=nodejs
    https://packages.ubuntu.com/search?searchon=names&suite=all&section=all&keywords=nodejs

So, requiring Node 10 and npm 6 going with it.
  • Loading branch information
ronjouch committed Jun 13, 2020
1 parent e5ba8c7 commit 8fa394a
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
10 changes: 5 additions & 5 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@ os:
- osx
- windows
node_js:
- '13'
- '12' # Changing this? Remind to keep linter+deploy conditions below aligned
- '8'
- '14' # Changing this? Remind to keep linter+deploy conditions below aligned
- '12'
- '10'
install:
- npm run dev-up
- npm run build
script:
# Only run linter once, for faster CI. Remind to keep linter+deploy conditions below aligned
- if [ "$TRAVIS_OS_NAME" = "linux" ] && [ "$TRAVIS_NODE_VERSION" = "12" ]; then npm run lint; fi
- if [ "$TRAVIS_OS_NAME" = "linux" ] && [ "$TRAVIS_NODE_VERSION" = "14" ]; then npm run lint; fi
- npm test
# https://docs.travis-ci.com/user/deployment
deploy:
Expand All @@ -24,5 +24,5 @@ deploy:
on:
tags: true
repo: jiahaog/nativefier
node_js: '12' # Remind to keep linter+deploy conditions above aligned
node_js: '14' # Remind to keep linter+deploy conditions above aligned
condition: '$TRAVIS_OS_NAME = linux'
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"license": "MIT",
"author": "Goh Jia Hao",
"engines": {
"node": ">= 8.10.0",
"npm": ">= 5.6.0"
"node": ">= 10.0.0",
"npm": ">= 6.0.0"
},
"keywords": [
"desktop",
Expand Down Expand Up @@ -84,7 +84,7 @@
"jest": "26.x",
"prettier": "2.x",
"rimraf": "3.x",
"ts-loader": "6.x",
"ts-loader": "7.x",
"typescript": "3.x",
"webpack": "4.x",
"webpack-cli": "3.x"
Expand Down

0 comments on commit 8fa394a

Please sign in to comment.