Skip to content

Commit

Permalink
sunxi: Fix H616 DRAM read calibration for dual rank
Browse files Browse the repository at this point in the history
Although it isn't known what bit 0 in PHY reg 8 does, it's obvious that
it has to be set before read calibration and cleared afterwards. This is
already done for first rank, but not for second (copy & paste error.)

Fix it.

Fixes: f4317db ("sunxi: Add H616 DRAM support")
Signed-off-by: Jernej Skrabec <[email protected]>
Reviewed-by: Andre Przywara <[email protected]>
Signed-off-by: Andre Przywara <[email protected]>
  • Loading branch information
jernejsk authored and Andre-ARM committed Jan 30, 2022
1 parent 18a5927 commit e97943b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/arm/mach-sunxi/dram_sun50i_h616.c
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ static bool mctl_phy_read_calibration(struct dram_para *para)
}
}

setbits_le32(SUNXI_DRAM_PHY0_BASE + 8, 1);
clrbits_le32(SUNXI_DRAM_PHY0_BASE + 8, 1);
}

clrbits_le32(SUNXI_DRAM_PHY0_BASE + 8, 0x30);
Expand Down

0 comments on commit e97943b

Please sign in to comment.