Update django-stubs to the latest upstream #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterJCLaw
force-pushed
the
update-django-stubs
branch
from
0ad83ee to
0f9312c
Compare
The approach taken by the upstream to the handling of Model.objects has changed, such that the property is now correctly on the class rather than on the instances. This allows us to move to the upstream directly rather than our own fork.
PeterJCLaw
force-pushed
the
update-django-stubs
branch
from
0f9312c to
249e462
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The approach taken by the upstream to the handling of Model.objects has changed, such that the property is now correctly on the class rather than on the instances. This allows us to move to the upstream directly rather than our own fork.