Fixed error on E3002 (aws-cloudformation#2059)

Co-authored-by: Kevin DeJong <[email protected]>
PetersonOlay · Aug 18, 2022 · d795fda · d795fda
1 parent 337e5d8
commit d795fda
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/docs/rules.md b/docs/rules.md
@@ -97,7 +97,7 @@ The following **148** rules are applied by this linter:
 | [E2541<a name="E2541"></a>](../src/cfnlint/rules/resources/codepipeline/CodepipelineStageActions.py) | CodePipeline Stage Actions | See if CodePipeline stage actions are set correctly |  | [Source](https://docs.aws.amazon.com/codepipeline/latest/userguide/reference-pipeline-structure.html#pipeline-requirements) | `resources`,`codepipeline` |
 | [E3000<a name="E3000"></a>](../src/cfnlint/rules/resources/ResourceSchema.py) | Resource schema | CloudFormation Registry resource schema validation |  | [Source](https://github.com/aws-cloudformation/aws-cloudformation-resource-schema/) | `resources` |
 | [E3001<a name="E3001"></a>](../src/cfnlint/rules/resources/Configuration.py) | Basic CloudFormation Resource Check | Making sure the basic CloudFormation resources are properly configured |  | [Source](https://github.com/aws-cloudformation/cfn-python-lint) | `resources` |
-| [E3002<a name="E3002"></a>](../src/cfnlint/rules/resources/properties/Properties.py) | Resource properties are valid | Making sure that resources properties are properly configured |  | [Source](https://github.com/aws-cloudformation/cfn-python-lint/blob/main/docs/cfn-resource-specification.md#properties) | `resources` |
+| [E3002<a name="E3002"></a>](../src/cfnlint/rules/resources/properties/Properties.py) | Resource properties are invalid | Making sure that resources properties are properly configured |  | [Source](https://github.com/aws-cloudformation/cfn-python-lint/blob/main/docs/cfn-resource-specification.md#properties) | `resources` |
 | [E3003<a name="E3003"></a>](../src/cfnlint/rules/resources/properties/Required.py) | Required Resource properties are missing | Making sure that Resources properties that are required exist |  | [Source](https://github.com/aws-cloudformation/cfn-python-lint/blob/main/docs/cfn-resource-specification.md#required) | `resources` |
 | [E3004<a name="E3004"></a>](../src/cfnlint/rules/resources/CircularDependency.py) | Resource dependencies are not circular | Check that Resources are not circularly dependent by DependsOn, Ref, Sub, or GetAtt |  | [Source](https://github.com/aws-cloudformation/cfn-python-lint) | `resources`,`circularly`,`dependson`,`ref`,`sub`,`getatt` |
 | [E3005<a name="E3005"></a>](../src/cfnlint/rules/resources/DependsOn.py) | Check DependsOn values for Resources | Check that the DependsOn values are valid |  | [Source](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-attribute-dependson.html) | `resources`,`dependson` |

diff --git a/src/cfnlint/rules/resources/properties/Properties.py b/src/cfnlint/rules/resources/properties/Properties.py
@@ -10,7 +10,7 @@
 class Properties(CloudFormationLintRule):
     """Check Base Resource Configuration"""
     id = 'E3002'
-    shortdesc = 'Resource properties are valid'
+    shortdesc = 'Resource properties are invalid'
     description = 'Making sure that resources properties are properly configured'
     source_url = 'https://github.com/aws-cloudformation/cfn-python-lint/blob/main/docs/cfn-resource-specification.md#properties'
     tags = ['resources']

diff --git a/test/integration/test_directives.py b/test/integration/test_directives.py
@@ -40,7 +40,7 @@ class TestDirectives(BaseCliTestCase):
                     'Rule': {
                         'Description': 'Making sure that resources properties are properly configured',
                         'Id': 'E3002',
-                        'ShortDescription': 'Resource properties are valid',
+                        'ShortDescription': 'Resource properties are invalid',
                         'Source': 'https://github.com/aws-cloudformation/cfn-python-lint/blob/main/docs/cfn-resource-specification.md#properties'
                     }
                 },
@@ -67,7 +67,7 @@ class TestDirectives(BaseCliTestCase):
                     'Rule': {
                         'Description': 'Making sure that resources properties are properly configured',
                         'Id': 'E3002',
-                        'ShortDescription': 'Resource properties are valid',
+                        'ShortDescription': 'Resource properties are invalid',
                         'Source': 'https://github.com/aws-cloudformation/cfn-python-lint/blob/main/docs/cfn-resource-specification.md#properties'
                     }
                 },
@@ -120,7 +120,7 @@ class TestDirectives(BaseCliTestCase):
                     'Rule': {
                         'Description': 'Making sure that resources properties are properly configured',
                         'Id': 'E3002',
-                        'ShortDescription': 'Resource properties are valid',
+                        'ShortDescription': 'Resource properties are invalid',
                         'Source': 'https://github.com/aws-cloudformation/cfn-python-lint/blob/main/docs/cfn-resource-specification.md#properties'
                     }
                 },

diff --git a/test/integration/test_mandatory_checks.py b/test/integration/test_mandatory_checks.py
@@ -30,7 +30,7 @@ class TestDirectives(BaseCliTestCase):
                     "Rule": {
                         "Description": "Making sure that resources properties are properly configured",
                         "Id": "E3002",
-                        "ShortDescription": "Resource properties are valid",
+                        "ShortDescription": "Resource properties are invalid",
                         "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/main/docs/cfn-resource-specification.md#properties",
                     },
                 },
@@ -51,7 +51,7 @@ class TestDirectives(BaseCliTestCase):
                     "Rule": {
                         "Description": "Making sure that resources properties are properly configured",
                         "Id": "E3002",
-                        "ShortDescription": "Resource properties are valid",
+                        "ShortDescription": "Resource properties are invalid",
                         "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/main/docs/cfn-resource-specification.md#properties",
                     },
                 },
@@ -92,7 +92,7 @@ class TestDirectives(BaseCliTestCase):
                     "Rule": {
                         "Description": "Making sure that resources properties are properly configured",
                         "Id": "E3002",
-                        "ShortDescription": "Resource properties are valid",
+                        "ShortDescription": "Resource properties are invalid",
                         "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/main/docs/cfn-resource-specification.md#properties",
                     },
                 },
@@ -135,7 +135,7 @@ class TestDirectives(BaseCliTestCase):
                     'Rule': {
                         'Description': 'Making sure that resources properties are properly configured',
                         'Id': 'E3002',
-                        'ShortDescription': 'Resource properties are valid',
+                        'ShortDescription': 'Resource properties are invalid',
                         'Source': 'https://github.com/aws-cloudformation/cfn-python-lint/blob/main/docs/cfn-resource-specification.md#properties'
                         }
                     },