Skip to content

Fix Implicitly marking parameter $maxItems as nullable is deprecated #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 24, 2025
Merged

Fix Implicitly marking parameter $maxItems as nullable is deprecated #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0203813
Fix Implicitly marking parameter $maxItems as nullable is deprecated
bytestream Sep 24, 2025
542215a
Change maxItems parameter to nullable integer
bytestream Sep 24, 2025
43614f1
Fix implicit nullable parameters deprecation in unit tests
PhrozenByte Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ArrayAssertsTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ public static function arrayHasKeyWith($key, $constraint): ArrayHasKeyWith
public static function assertSequentialArray(
$array,
int $minItems,
int $maxItems = null,
?int $maxItems = null,
$constraint = null,
bool $ignoreKeys = false,
string $message = ''
Expand All @@ -185,7 +185,7 @@ public static function assertSequentialArray(
*/
public static function sequentialArray(
int $minItems,
int $maxItems = null,
?int $maxItems = null,
$constraint = null,
bool $ignoreKeys = false
): SequentialArray {
Expand Down
2 changes: 1 addition & 1 deletion src/Constraint/SequentialArray.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ class SequentialArray extends Constraint
*
* @throws InvalidArgumentException
*/
public function __construct(int $minItems = 0, int $maxItems = null, $constraint = null, bool $ignoreKeys = false)
public function __construct(int $minItems = 0, ?int $maxItems = null, $constraint = null, bool $ignoreKeys = false)
{
if ($minItems < 0) {
throw InvalidArgumentException::create(1, 'non-negative integer');
Expand Down
2 changes: 1 addition & 1 deletion tests/TestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ abstract class TestCase extends \PHPUnit\Framework\TestCase
protected function mockConstraint(
$constraint,
array $invocationRules = [],
array $evaluateParameters = null
?array $evaluateParameters = null
) {
if (!($constraint instanceof Constraint)) {
return $constraint;
Expand Down
2 changes: 1 addition & 1 deletion tests/Unit/ArrayAssertsTraitTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@ public function dataProviderArrayHasItemWithFail(): array
private function mockConstraintInstance(
string $className,
array $constructorArguments = [],
array $evaluateArguments = null
?array $evaluateArguments = null
): MockInterface {
$instanceMock = Mockery::mock('overload:' . $className, Constraint::class);

Expand Down
Loading